search

oxidecomputer / design-site

We are looking for designers who code to help build a new user experience for computing!
https://design.oxide.computer
MIT License
98 stars 34 forks source link

Modern centering & box-sizing #8

Closed NikiSkaarup closed 4 years ago

NikiSkaarup commented 4 years ago

User Case: Send a PR with any improvement

Solution: Bugged me that position absolute and translate was being used for centering, so I rewrote those bits with flexbox and viewwidth and viewheight units, which have been supported by almost all browsers since 2012-2013.

And I added box-sizing for reduced mental book keeping for sizes.

All this causes a slight move of the text on desktop due to the slight off centering it had initially, even with compensation.

jessfraz commented 4 years ago

Looks great! Do you want to move this out of draft mode and into ready to review?

NikiSkaarup commented 4 years ago

Wups, I forgot make it a non draft, had set it to draft because I was still working on while writing it, but never submitted it before I was done anyway.

jessfraz commented 4 years ago

awesome thanks! can you fix the file conflict?

jessfraz commented 4 years ago

Awesome thank you!