search

oxidecomputer / helios

Helios: Or, a Vision in a Dream. A Fragment.
Mozilla Public License 2.0
371 stars 10 forks source link

image: Update token values to new enum variants now that we know #154

Closed daym closed 6 months ago

daym commented 6 months ago

With new processor generations, sometimes AMD describes meanings of some of the old tokens that previously had only empirical meaning. Previously, we didn't actually know what exactly ConsoleOutMode's and MemTrainingHdtControl's values meant so we used placeholders.

Now that we know the meanings for Genoa, let's also use them for Milan.

See also https://github.com/oxidecomputer/amd-apcb/commit/5a35018e09eb452b2d8baa50555c305def21bdb6#diff-88041fcad5b235e8943f0bdaab24e9d658e74dd8c91978e6bf60ed0eba0e566fR8564 and https://github.com/oxidecomputer/amd-apcb/commit/5a35018e09eb452b2d8baa50555c305def21bdb6#diff-88041fcad5b235e8943f0bdaab24e9d658e74dd8c91978e6bf60ed0eba0e566fR7232 for the corresponding changes in amd-apcb.

jclulow commented 6 months ago

Can we update the synopsis here to reflect a bit closer to the actual visible result of the change haha

daym commented 6 months ago

Done, I think :)