search

oxidecomputer / helios

Helios: Or, a Vision in a Dream. A Fragment.
Mozilla Public License 2.0
333 stars 9 forks source link

APCB configuration should not include BMC early link training #64

Open wesolows opened 1 year ago

wesolows commented 1 year ago

The current example blob configuration for Gimlet in amd-host-image-builder leaves intact the Ethanol-X early PCIe link training configuration used to connect with the BMC. This doesn't exist at all on Gimlet and the feature should be disabled in our Gimlet configuration.

wesolows commented 10 months ago

Somehow this was moved to the Done state in the external milestone tracker (which I do not believe should ever be done except by the bot) but is still open here. It looks like there was an attempt to address this via 71bcc9576a6d8cb791d26ea0c9ea2de6245e4c17; should this bug be closed? The commit message referenced #76, not this bug, so I can't tell what was intended. All commit messages should include a single line identifying each bug or RFE that it addresses, in the form

repo#bugno verbatim synopsis of the bug from the ticketing system

If the repository is illumos-gate master, the repo# portion should be omitted and a list of reviewers included after the list of tickets; see documentation at illumos.org.

That makes it easy to determine whether a ticket has inadvertently been left open. Has this one, or is there still work to be done?