oxidecomputer / hubris

A lightweight, memory-protected, message-passing kernel for deeply embedded systems.
Mozilla Public License 2.0
3.02k stars 175 forks source link

Inconsistencies in tech port unlock behavior #1839

Open mkeeter opened 3 months ago

mkeeter commented 3 months ago

control-plane-agent and net store unlock state on a per-VLAN basis. However, monorail does not; it enables all tech ports when unlocked. This could be confusing if someone sends unlock commands on multiple ports; monorail's time-based unlock will fire at the time set by the most recent unlock.

We should either

I'm leaning towards the latter, because it's hard to imagine a case where someone authorized is connected to TP1 and someone malicious is connected to TP2.