search

oxidecomputer / hubris

A lightweight, memory-protected, message-passing kernel for deeply embedded systems.
Mozilla Public License 2.0
3.02k stars 175 forks source link

chore: Cleanup userlib namespace imports #1855

Closed aapoalas closed 3 months ago

aapoalas commented 3 months ago

Didn't quite have the time to get rid of all of these, but I removed a bunch of userlib namespace imports.

These were mentioned in a PR nearly half a year ago and I "helpfully" went through and pointed out those that were in the PR, so this is my atonement.

Each task is done in a separate commit here. All others except drv-lpc55-spi-server is tested to cause no build errors, or I think anyway. I'm randomly building tasks based on searches into the repository with the device name, and testing that they fail if I remove the userlib::* import entirely, and then add imports until build works.

cbiffle commented 3 months ago

(Whoever merges this, please squash before merge and take the PR text so there's more explanation of the purpose)

aapoalas commented 3 months ago

I'm planning on removing the rest of them as well; given that these changes actually change nothing in the resulting code, it is fine to me merge this and make a second PR for the rest or keep this waiting until finish the cleanup. Either is okay.

cbiffle commented 3 months ago

Alright, rebased and set to autosquash on success.

cbiffle commented 3 months ago

I'm planning on removing the rest of them as well; given that these changes actually change nothing in the resulting code, it is fine to me merge this and make a second PR for the rest or keep this waiting until finish the cleanup. Either is okay.

Naw, no reason to carry the PR longer than is necessary. If you want to clean up more things, that's great, but this PR is a marginal improvement and I'd like to go ahead and merge it.

aapoalas commented 3 months ago

Naw, no reason to carry the PR longer than is necessary. If you want to clean up more things, that's great, but this PR is a marginal improvement and I'd like to go ahead and merge it.

Sure thing!