search

oxidecomputer / hubris

A lightweight, memory-protected, message-passing kernel for deeply embedded systems.
Mozilla Public License 2.0
3.04k stars 180 forks source link

Drop gdb file from the archive #1891

Closed labbott closed 1 month ago

labbott commented 2 months ago

This file contains local paths which reduces reproducibility. The local paths also mean it's not useful in the archive anyway.

mkeeter commented 2 months ago

This will break humility gdb with

GDB script missing. Is your Hubris build too old?

(ironically)

Since it changes Humility compatibility, it should technically be a Hubris version bump. I don't feel too pedantic about it, though, since folks usually aren't using humility gdb; curious to hear other opinions.

Either way, we probably want a new --gdb-script argument to humility gdb, so it can either pull the script from the archive or use a local script.

labbott commented 2 months ago

I had forgotten humility gdb was even a thing (and here I was running it manually...). I'm inclined to let this break with an error message to pass the script in manually in humility.

cbiffle commented 2 months ago

As probably the main user of humility gdb at this point, I'd be comfortable updating the Humility error message to read

GDB script missing; recent archives don't include it. Pass --gdb-script

and not rev the archive version.

cbiffle commented 2 months ago

Better yet...

GDB script missing; recent archives don't include it because humility gdb is deprecated, use xtask gdb

labbott commented 2 months ago

https://github.com/oxidecomputer/humility/pull/510 associated humility change