oxidecomputer / humility

Debugger for Hubris
Mozilla Public License 2.0
529 stars 51 forks source link

lsusb: fix backwards VID:PID output #480

Closed hawkw closed 6 months ago

hawkw commented 6 months ago

I just lost a kind of embarassing amount of time to the fact that humility lsusb claims to print USB devices in the format VID:PID:SERIAL, but actually outputs PID:VID:SERIAL. To spare others from the suffering this caused me, this commit changes the command to actually print what it says it does.

I chose to bring the output in line with the help text, rather than the other way around, because the help text's format is the same format used by the --probe CLI flag and the environment.json file format, and using PID:VID:SERIAL with --probe or in the config file will make Humility unhappy.

Fixes #479