oxidecomputer / maghemite

A routing stack written in Rust.
Mozilla Public License 2.0
36 stars 2 forks source link

BGP capability parsing should tolerate unknown capability codes better #322

Closed rcgoodfellow closed 3 months ago

rcgoodfellow commented 3 months ago

When we receive a BGP open message with an unknown capability code we immediately send a notification to the peer and tear down the session. That's not terribly robust. We should instead chalk the capability up to an unknown capability (and not advertise it ourselves).

An example of how this can have unfortunate consequences is FRR 10.1 started advertising the dynamic capability by default and this prevented us from peering with 10.1 with default settings :/