Closed internet-diglett closed 1 year ago
Let me know if I can help with this. I think the basic approach would be to add it to ControlPlaneTestContext
, as most of the tests that set up a control plane for testing use that to get CockroachDB, simulated sled agent, oximeter, etc.
With the integration of
dendrite
intoomicron
, we have added another service that changes configuration and behavior depending on howomicron
has been packaged, which somewhat complicates running tests. Since the correct variant ofdpd
is only pulled whenomicron-package
is run, we need to do a bit of extra work to get the correct version ofdendrite-stub
installed in development and testing environments, and then integrate its setup into the test suite setup code.As a stopgap, we are conditionally bypassing the calls to
dendrite
inomicron/nexus/src/app/sagas/instance_delete.rs
andomicron/nexus/src/app/sagas/instance_create.rs
when the environment variableSKIP_ASIC_CONFIG
is set. Once the above is addressed, we can remove that.dendrite-stub
dependency, or create an in-place stubSKIP_ASIC_CONFIG
switch from relevant sagas.