search

oxidecomputer / omicron

Omicron: Oxide control plane
Mozilla Public License 2.0
251 stars 40 forks source link

Consider making infra-ip ranges implicit #3591

Open internet-diglett opened 1 year ago

internet-diglett commented 1 year ago 
    // TODO: Consider making infra-ip ranges implicit for uplinks

https://github.com/oxidecomputer/omicron/blob/973bff16f09d0bf9fca03641053c8ebd88c46b72/common/src/api/internal/shared.rs#L73-L77

Reference discussion https://github.com/oxidecomputer/omicron/pull/3262#discussion_r1256401435

rcgoodfellow commented 1 year ago

I'm not sure if it was part of the intent of this bug, but one of the limitations here is that we require all infrastructure addresses used in setup to fall within a contiguous range. This is overly restrictive.

rmustacc commented 1 year ago

Yeah, this stood out to me as well while reviewing the docs.

internet-diglett commented 1 year ago

Agreed. I think resolving this would also solve for that problem.