search

oxidecomputer / omicron

Omicron: Oxide control plane
Mozilla Public License 2.0
251 stars 39 forks source link

Prevent default silo from showing up in utilization response #5731

Open askfongjojo opened 6 months ago

askfongjojo commented 6 months ago

From the comment in https://github.com/oxidecomputer/omicron/pull/4943:

I've updated the /v1/system/utilization/silos endpoint to only return non-discoverable silos if they have a quota set. I believe the default-silo does get a quota set currently which is non-ideal, but that should be the only one that shows up on the list.

The default silo currently has all 9s for their quotas by default so they do show up in the Utilization UI. New customers will see them the first time they get on the rack.

david-crespo commented 6 months ago

We may want to handle this client-side if the silo in question has a well-known name.

augustuswm commented 6 months ago

It looked like the default-silo also affected the silo utilization totals, which largely skews them.

davepacheco commented 5 months ago

I think we can and should remove the default silo altogether (#2305). That's a bit of work, and not saying we should definitely do it instead, but if hiding it turns out to be non-trivial, it may make more sense to just do the removal.