Extra space in help output for `oxide system networking bgp announce-set list`

[elaine-oxide]

I am running a4x2 with:

• omicron 1059fe109fadbccf559e4adad134eaffcb67b85a
• Oxide CLI from branch in https://github.com/oxidecomputer/oxide.rs/pull/795 commit 98f000bfc68b375e49888ff6946ffa988092084e with merge from https://github.com/oxidecomputer/oxide.rs/pull/808 commit 457db93dc13a09d45df09597dd0a3c1becd0b086, resolved merge conflicts by hand. Then copied above version of omicron openapi/nexus.json to oxide.json. Then applied the following diff.

  
  $ git diff
  diff --git a/cli/src/cli_builder.rs b/cli/src/cli_builder.rs
  index 242f3c1..e1cc101 100644
  --- a/cli/src/cli_builder.rs
  +++ b/cli/src/cli_builder.rs
  @@ -479,6 +479,9 @@ fn xxx<'a>(command: CliCommand) -> Option<&'a str> {
           Some("system networking bgp announce-set delete")
       }
       CliCommand::NetworkingBgpAnnounceSetList => Some("system networking bgp announce-set list"),

• CliCommand::NetworkingBgpAnnouncementList => {
• Some("system networking bgp announcement list")
• } CliCommand::NetworkingBgpImportedRoutesIpv4 => Some("system networking bgp imported ipv4"), CliCommand::NetworkingBgpExported => Some("system networking bgp exported"),

diff --git a/cli/src/cmd_net.rs b/cli/src/cmd_net.rs index 0193c45..2a0510e 100644 --- a/cli/src/cmd_net.rs +++ b/cli/src/cmd_net.rs @@ -259,7 +259,7 @@ pub struct CmdBgpAnnounce { impl AuthenticatedCmd for CmdBgpAnnounce { async fn run(&self, client: &Client) -> Result<()> { let mut current: Vec = client

• .networking_bgp_announce_set_list()
• .networking_bgp_announcement_list() .name_or_id(NameOrId::Name(self.announce_set.clone())) .send() .await? @@ -311,7 +311,7 @@ pub struct CmdBgpWithdraw { impl AuthenticatedCmd for CmdBgpWithdraw { async fn run(&self, client: &Client) -> Result<()> { let mut current: Vec = client
• .networking_bgp_announce_set_list()
• .networking_bgp_announcement_list() .name_or_id(NameOrId::Name(self.announce_set.clone())) .send() .await?

I ran the following:

$ oxide system networking bgp announce-set list --help
List BGP announce sets

Usage: oxide system networking bgp announce-set list [OPTIONS]

Options:
      --limit <limit>            Maximum number of items returned by a single call
      --name-or-id <name-or-id>  A name or id to use when s electing BGP port settings
      --profile <PROFILE>        Configuration profile to use for commands
      --page-token <page-token>  Token returned by previous call to retrieve the subsequent page
      --sort-by <sort-by>        [possible values: name_ascending, name_descending, id_ascending]
  -h, --help                     Print help

I note there is an extra space in "s electing".

[elaine-oxide]

Fixed/changed in https://github.com/oxidecomputer/omicron/pull/6498