oxidecomputer / omicron

Omicron: Oxide control plane
Mozilla Public License 2.0
244 stars 38 forks source link

two different Rust packages called `dpd-client` #6666

Open davepacheco opened 4 days ago

davepacheco commented 4 days ago

In our system we have two distinct packages called dpd-client:

Rust package names are supposed to be unique. This happens to work, maybe because the packages in the above two groups are never built in the same workspace? Based on this comment: https://github.com/oxidecomputer/omicron/blob/68583ad7e931bfbab5f9b7c3aff9789609c84129/clients/dpd-client/build.rs#L5-L11

I gather that these clients are about equivalent and the second one exists only because the first one is private? But Maghemite is also public but still seems to use the (private) Dendrite client.

The new ls-apis tool works around this: https://github.com/oxidecomputer/omicron/blob/68583ad7e931bfbab5f9b7c3aff9789609c84129/dev-tools/ls-apis/src/workspaces.rs#L157-L195