Rename static route local_pref to rib_priority

oxidecomputer / omicron

Omicron: Oxide control plane

Mozilla Public License 2.0

252 stars 40 forks source link

Rename static route local_pref to rib_priority #6693

Closed taspelund closed 1 month ago

taspelund commented 1 month ago

This is the omicron half of maghemite#359. This renames the local_pref field of static routes to rib_priority to avoid overloading the name of a standardized and well-known BGP attribute (Local Preference). This change shrinks the size of the field from u32 -> u8 and unwraps the Option before shipping routes to mgd, aligning with the updated API. This also brings omicron back into sync with maghemite.

Fixes: #6711

Signed-off-by: Trey Aspelund trey@oxidecomputer.com

ahl commented 1 month ago

Can you please address #6711 in this PR as well?

rcgoodfellow commented 1 month ago

Something potentially helpful here is this script

https://github.com/oxidecomputer/omicron/blob/main/tools/update_maghemite.sh

rcgoodfellow commented 1 month ago

Noting that because this is changing the external API, there will need to be a corresponding update to oxide.rs