Open jgallagher opened 2 days ago
We've noted this in a TODO: https://github.com/oxidecomputer/omicron/blob/ac3fb34a7621afcc8a2ad89a99821adf704b5dc0/common/src/disk.rs#L110-L113
and @andrewjstone noted confusion in https://github.com/oxidecomputer/omicron/pull/7104#discussion_r1849236965. It would be a little disruptive to make that change as a part of that PR; opening this to remind me to go back and actually do this.
We've noted this in a TODO: https://github.com/oxidecomputer/omicron/blob/ac3fb34a7621afcc8a2ad89a99821adf704b5dc0/common/src/disk.rs#L110-L113
and @andrewjstone noted confusion in https://github.com/oxidecomputer/omicron/pull/7104#discussion_r1849236965. It would be a little disruptive to make that change as a part of that PR; opening this to remind me to go back and actually do this.