oxidecomputer / omicron

Omicron: Oxide control plane
Mozilla Public License 2.0
252 stars 40 forks source link

Log files are not rotated to crypt/debug datasets on "synthetic" disks #7116

Open jmpesp opened 1 day ago

jmpesp commented 1 day ago

In dump_setup.rs, synthetic disks are skipped in a loop that determines which datasets to use for both dump devices and where to put rotated log files:

https://github.com/oxidecomputer/omicron/blob/a73bc0da5eeebe2f98d6a5633c09170d8e613843/sled-agent/src/dump_setup.rs#L243-L246

It makes sense that we wouldn't configure a dump device on a synthetic disk, but a casualty of this is that log files are not moved to any crypt/debug for synthetic disks, which means that simulated setups will have their logs rotated away after 8 days.