oxidecomputer / oxide.rs

The Oxide Rust SDK and CLI
Mozilla Public License 2.0
38 stars 13 forks source link

CLI: VPC subnet routing #723

Closed FelixMcFelix closed 3 months ago

FelixMcFelix commented 3 months ago

This PR manually adds oxide router <x> and oxide router route <x> commands on top of the dependency updates from #716.

The individual route create/update commands do require full json-body inputs, but I think this is hard to avoid right now given that they're on a similar level of complexity to firewall rules. I'm curious about what we can do here in future.

ahl commented 3 months ago

Is this the same as #716?

FelixMcFelix commented 3 months ago

Ack, it is! Sorry, I hadn't realised that you'd fixed up and merged that PR. Apologies for the noise.

ahl commented 3 months ago

I had noticed that you already started this. We automatically pull in changes; pretty quickly after omicron updates; if you want to take those over in the future feel free to leave a comment or assign to yourself.