Closed wfchandler closed 1 month ago
Sorry to bombard you with reviews @ahl, are there any other maintainers I can spread these out to?
Sorry to bombard you with reviews @ahl, are there any other maintainers I can spread these out to?
I think I'm on the only one with state on why things are the way they are and where they're going. I feel like you're on a trajectory to shouldering some of that load.
Piping command output to a process that performs a partial read before closing the pipe, such as
head
, will cause anEPIPE
to be raised on the next write attempt. The standard(e)print(ln)!
macros will panic on any errors when writing, includingEPIPE
. One option to handle this is to switch towrite(ln)!
, but this will inject new requirements to handleResult
where used, which can be onerous.Create wrappers around the print macros to ignore
EPIPE
, and replace calls to the originals with them. Updatemain
to ignore anyEPIPE
s returned fromwriteln!
calls in subcommands.We deliberately do not make this change to the
auth login/logout
subcommands as these are mutating the config. Failure to notify the user of the changes is fatal.Before:
After: