search

oxidecomputer / phbl

Pico Host Boot Loader
Mozilla Public License 2.0
98 stars 7 forks source link

idt: Use modular-bitfield. #7

Closed daym closed 2 years ago

dancrossnyc commented 2 years ago

This triples the code size and adds a dependency on another external library that's basically redundant with bitstruct; I don't quite feel like it pulls its weight, though if we wanted to go this route I'd think we could use bitstruct as in https://github.com/hypatia-hypervisor/hypatia/blob/main/x86_64/src/segment.rs#L119

What do you think?

dancrossnyc commented 2 years ago

FYI, I opened PR#10 that is basically this change, but written in terms of bitstruct, guided by the Hypatia implementation.

daym commented 2 years ago

This triples the code size and adds a dependency on another external library that's basically redundant with bitstruct; I don't quite feel like it pulls its weight, though if we wanted to go this route I'd think we could use bitstruct as in https://github.com/hypatia-hypervisor/hypatia/blob/main/x86_64/src/segment.rs#L119

What do you think?

I agree--let's just use bitstruct. I saw you already have a PR with it :)

daym commented 2 years ago

Abandoned in favor of https://github.com/oxidecomputer/phbl/pull/10