oxidecomputer / progenitor

An OpenAPI client generator
417 stars 54 forks source link

api.github.com #444

Open jayvdb opened 1 year ago

jayvdb commented 1 year ago

When I fetch the latest from https://github.com/github/rest-api-description (it has the same version but it is not the same api), I encounter the following five parse errors. yes, there are only five.

  1. fails in typify schemas_mutually_exclusive due to this field.
"conditions": {
            "anyOf": [
              {
                "$ref": "#/components/schemas/repository-ruleset-conditions"
              },
              {
                "$ref": "#/components/schemas/org-ruleset-conditions"
              }
            ]
          },
  1. /markdown/raw handles two media types , text/plain and text/x-markdown .
  2. Fails due to this:
"422": {
            "description": "Validation failed",
            "content": {
              "application/json": {
                "schema": {
                  "oneOf": [
                    {
                      "$ref": "#/components/schemas/validation-error"
                    },
                    {
                      "$ref": "#/components/schemas/validation-error-simple"
                    }
                  ]
                }
              }
            }
          },
  1. Fails due to this
                  "make_latest": {
                    "type": "string",
                    "description": "Specifies whether this release should be set as the latest release for the repository. Drafts and prereleases cannot be set as latest. Defaults to `true` for newly published releases. `legacy` specifies that the latest release should be determined based on the release creation date and higher semantic version.",
                    "enum": [
                      "true",
                      "false",
                      "legacy"
                    ],
                    "default": true
                  },
  1. response_types.len() <= 1', progenitor-impl/src/method.rs:1171:9 https://github.com/oxidecomputer/progenitor/issues/344
jayvdb commented 1 year ago

Looks like this overlaps with https://github.com/oxidecomputer/progenitor/issues/395

augustuswm commented 1 year ago

I believe all of these are covered in #395, except for maybe the first one. Can you add any details (and the build errors) to the tracking ticket and I'll update the list of issues for building a GitHub client.