search

oxidecomputer / third-party-api-clients

A place for keeping all our generated third party API clients.
https://docs.rs/octorust
MIT License
132 stars 55 forks source link

sheets: Remove unused dependency and unused feature #1

Closed fenhl closed 3 years ago

fenhl commented 3 years ago

This removes the hyperx dependency, which was unused and causes issues with dependency resolution (see dekellum/hyperx#33), from sheets. It also removes an unused #![feature(async_stream)], allowing the crate to once again compile on stable Rust.

jessfraz commented 3 years ago

These are generated, so change the generator not the library. THanks!

Susurrus commented 2 years ago

@jessfraz where is the generator project/code? I'm trying to use the Google Sheets API, and the issues resolved in #3 would be very useful to get upstreamed here. However, it's clear that's not the right way to include these changes, however it's not clear to me how to do this. I don't see anything in the README, there's no CONTRIBUTOR doc, and noting in the project metadata on Github. However, I did find Progenitor, is that where this kind of change should be upstreamed?

jessfraz commented 2 years ago

It’s in the generator folder….

On Nov 14, 2021, at 2:46 PM, Bryant Mairs @.***> wrote:

 @jessfraz where is the generator project/code? I'm trying to use the Google Sheets API, and the issues resolved in !3 would be very useful to get upstreamed here. However, it's clear that's not the right way to include these changes, however it's not clear to me how to do this. I don't see anything in the README, there's no CONTRIBUTOR doc, and noting in the project metadata on Github. However, I did find Progenitor, is that where this kind of change should be upstreamed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.