Closed augustuswm closed 1 year ago
Thanks @augustuswm !
Hi! Any chance of getting reqwest-middleware ecosystem bumped from 0.1 to 0.2 in this release?
Definitely, that should already be in actually. There are a few changes that are missing from the PR description that I need to add. In the meantime https://github.com/oxidecomputer/third-party-api-clients/blob/rc-build/CHANGELOG.md has a better list of the upcoming changes.
@augustuswm I tried the rc build of octorust and pretty much everything went well after appending .body
to the old client calls.
I tried the download_artifact
call and was able to access .headers.get(reqwest::header::LOCATION)
to get the actual URL of the artifacts.
I did not give it a proper "prod" run, but was able to quickly run a service that collects GH actions workflow runs/jobs metrics with no issue.
Great, going to get a RC version published today. Definitely let me know if you run into any issues with it. There are still a couple changes that I might add in to this release, particularly around calls which panic instead of returning errors.
This has been working nicely for my use case BTW.
Release candidate 1 for 0.7.0.
anyhow::Result<T>
over some structured interpretation of the response body (i.e. a deserialized struct, a unit type, or a raw string). Methods now return aResult<Response<T>, ClientError>
where aResponse<T>
contains the bodyT
that was previously returned along with the status code and headers that were sent from the third party service.reqwest-middleware
ecosystem.