oxidecomputer / typify

JSON Schema -> Rust type converter
Apache License 2.0
367 stars 53 forks source link

`schemas_mutually_exclusive` should be conservative rather than panicking #616

Closed ahl closed 1 week ago

ahl commented 3 weeks ago

Today schemas_mutually_exclusive contains a couple of cases where it will panic on a todo!(). Since this check for mutual exclusion is 1. kind of janky and 2. needs to be conservative, we should simply return false (i.e. not mutually exclusive) in those cases rather than panicking.