search

oxidize-rb / rb-sys

Easily build Ruby native extensions in Rust
https://oxidize-rb.github.io/rb-sys/
Apache License 2.0
230 stars 35 forks source link

Update syn to 2.0 #231

Closed matsadler closed 1 year ago

matsadler commented 1 year ago

This takes the changes from #171 (Thanks @dylanahsmith, hope you don't mind), rebases them on main, and adds a couple more.

The motivation behind this is, I've updated Magnus to syn 2.0 and it'd be nice to have rb-sys and Magnus be able to use the same syn so it only need to be compiled once.

The biggest change is probably upping the minimum supported Rust version to 1.60, so that bindgen can be updated to 0.66, so that its syn dependency is upped to 2.0. Without this change the whole motivation for making any change is lost. Increasing the MSRV isn't something that bothers me right now as I'm going to be increasing it to 1.61 in Magnus, but if it doesn't work with your plans, then no worries, this whole change is just a nice to have, not critical, I'd be ok with dropping it.

dylanahsmith commented 1 year ago

This takes the changes from #171 (Thanks @dylanahsmith, hope you don't mind)

Much appreciated, since I wasn't planning on continuing that work after being laid off from my job at Shopify

ianks commented 1 year ago

I'm 👍🏻 with this, 1.60 is available on latest ubuntu for users that don't use rustup.