oxidizing / letters

Letters is an OCaml library for creating and sending emails over SMTP using LWT
MIT License
54 stars 6 forks source link

No default port 587 in the lib/sendmail_handler.ml #52

Open F-Loyer opened 1 year ago

F-Loyer commented 1 year ago

In the sendmail_handler.ml, I guess we should read

let run_with_starttls
    ~hostname
    ?port
    ~domain
    ?authentication
    ~tls_authenticator
    ~from
    ~recipients
    ~mail
  =
  let port =
    match port with
    | Some port -> port
    | None -> 587
  in

Instead, we have None -> 465

aronerben commented 1 year ago

@F-Loyer You're probably right. @mikonieminen @joseferben Ping