Use p7zip in unpack_cmd: the legend continues

oxinabox / DataDeps.jl

reproducible data setup for reproducible science

Other

150 stars 43 forks source link

Use p7zip in unpack_cmd: the legend continues #127

Closed omus closed 3 years ago

omus commented 3 years ago

Adds BinaryProvider support to https://github.com/oxinabox/DataDeps.jl/pull/123.

omus commented 3 years ago

Looks like the CI failed due to a networking issue. Restarting

omus commented 3 years ago

There are some issues with the unpacking code which need addressing

omus commented 3 years ago

Note the build_*.jl script was generated using modified instructions from: https://github.com/JuliaPackaging/Yggdrasil#binaryproviderjl

The modified instructions I did were:

git clone https://github.com/JuliaPackaging/Yggdrasil
cd Yggdrasil
git checkout 6c66c148
julia-1.5 -e 'using Pkg; Pkg.add(["GitHub", "BinaryBuilder"])'

# Remove `auth=BinaryBuilder.github_auth()` from `generate_buildjl.jl`
julia-1.5 --color=yes generate_buildjl.jl P/p7zip/build_tarballs.jl JuliaBinaryWrappers/p7zip_jll.jl p7zip-v16.2.0+4

Then I attempted to use the build file on Julia 1.0 and addressed the issues as I found them.

omus commented 3 years ago

Another curl issue. These tests could probably be revised to be more reliable

omus commented 3 years ago

The curl issue turned out to be binary dependencies interfering with Base.download. Removing check_deps() in __init__() avoids modifying DYLD_LIBRARY_PATH which is what is interferring with Base.download on Julia 1.0 and 1.1 on Linux 64-bit and macOS. See: https://github.com/JuliaLang/julia/issues/33585#issuecomment-543286618.

Here's the CI run where I test against 1.0 and 1.1.

oxinabox commented 3 years ago

Other than the missing compat, looks good to me.

oxinabox commented 3 years ago

Nice work @zerefwayne and @omus , thanks!