search

oxinabox / DataDepsGenerators.jl

Utility for developers to help define DataDeps registration blocks, for reusing existing Data with DataDeps.jl
Other
18 stars 6 forks source link

Adding build status badges #16

Closed SebastinSanty closed 6 years ago

SebastinSanty commented 6 years ago

DataDeps contains status badges so I thought it would be a good idea to include them for this project too.

codecov-io commented 6 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files           6        6           
  Lines          96       96           
=======================================
  Hits           93       93           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d9ef09...9f3f1f7. Read the comment docs.

oxinabox commented 6 years ago

Looks good. I feel like PkgDev used to automatically include these in the template file

Need to update AppVeyor's badge's security token based badge image url

What do you mean? Seem to be working to me

SebastinSanty commented 6 years ago

The AppVeyor badge which is there right now is taken from DataDeps.jl and hence will reflect that package's status. I think only you will be able to get the badge image for this package from your AppVeyor dashboard.

On Tue, 8 May 2018, 09:06 Lyndon White, notifications@github.com wrote:

Looks good. I feel like PkgDev used to automatically include these in the template file

Need to update AppVeyor's badge's security token based badge image url

What do you mean? Seem to be working to me

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oxinabox/DataDepsGenerators.jl/pull/16#issuecomment-387274510, or mute the thread https://github.com/notifications/unsubscribe-auth/ANKBzPCRLM_7zzVjAs6ZfSeKDyjYtk6Rks5twRLRgaJpZM4T1gEx .

oxinabox commented 6 years ago

Ah right, i get it. Cool, I have grabbed that and fixed it. Thanks.