Closed SebastinSanty closed 6 years ago
I suggest the capitalization be DataOneV2
not DataOnev2
Merging #21 into master will decrease coverage by
10.62%
. The diff coverage is52%
.
@@ Coverage Diff @@
## master #21 +/- ##
===========================================
- Coverage 96.2% 85.57% -10.63%
===========================================
Files 7 12 +5
Lines 158 208 +50
===========================================
+ Hits 152 178 +26
- Misses 6 30 +24
Impacted Files | Coverage Δ | |
---|---|---|
src/DataOneV2/KNB.jl | 0% <0%> (ø) |
|
src/DataOneV2/ArcticDataCenter.jl | 0% <0%> (ø) |
|
src/DataOneV2/KnowledgeNetworkforBiocomplexity.jl | 0% <0%> (ø) |
|
src/DataOneV2/TERN.jl | 100% <100%> (ø) |
|
src/DataDepsGenerators.jl | 90% <33.33%> (-6.3%) |
:arrow_down: |
src/DataOneV2/DataOneV2.jl | 81.25% <81.25%> (ø) |
|
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4261d42...a8fdf11. Read the comment docs.
Few points to make:
It happens that DataDryad is on a older version of DataOne API, hence what was described yesterday didn’t quite turn out as expected. Hence, I made a common base for DataOnev2 which includes KNB which in turn supports ArcticDataCenter. I was not able to find any other API (I was trying to get TERN AU, but didn’t work), hence it would be very helpful if you can point me to a few. Also, Merritt by UC3 which is supposed to be on DataOne API supports a completely different API.
Though ArcticDataCenter(ADC) mentions that it runs its API through KNB (check here), I was not able to get ADC examples working with its API other than the one example mentioned in that doc.