oxinabox / DataDepsGenerators.jl

Utility for developers to help define DataDeps registration blocks, for reusing existing Data with DataDeps.jl
Other
18 stars 6 forks source link

Implement DataOneV2 abstraction #21

Closed SebastinSanty closed 6 years ago

SebastinSanty commented 6 years ago

Few points to make:

oxinabox commented 6 years ago

I suggest the capitalization be DataOneV2 not DataOnev2

codecov-io commented 6 years ago

Codecov Report

Merging #21 into master will decrease coverage by 10.62%. The diff coverage is 52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #21       +/-   ##
===========================================
- Coverage    96.2%   85.57%   -10.63%     
===========================================
  Files           7       12        +5     
  Lines         158      208       +50     
===========================================
+ Hits          152      178       +26     
- Misses          6       30       +24
Impacted Files Coverage Δ
src/DataOneV2/KNB.jl 0% <0%> (ø)
src/DataOneV2/ArcticDataCenter.jl 0% <0%> (ø)
src/DataOneV2/KnowledgeNetworkforBiocomplexity.jl 0% <0%> (ø)
src/DataOneV2/TERN.jl 100% <100%> (ø)
src/DataDepsGenerators.jl 90% <33.33%> (-6.3%) :arrow_down:
src/DataOneV2/DataOneV2.jl 81.25% <81.25%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4261d42...a8fdf11. Read the comment docs.