Closed SebastinSanty closed 6 years ago
What do you think about the idea putting the integration tests in with the reference tests?
E.g.
@testset "BuzzFeedNews (whole repos)" begin
@testset "Pres Camp" begin
registration_code = generate(GitHub(), "https://github.com/BuzzFeedNews/presidential-campaign-contributions")
@testset "Integration Test" begin
eval(parse(registration_code)) # evaluate the new code
@test length(collect(readdir(datadep"Presidential Campaign Contributions"))) > 0
end
@test_reference "references/buzzfeed pres-camp.txt" registration_code # See if new code is same as old
end
@test_reference "references/buzzfeed primates.txt" generate(GitHub(), "BuzzFeedNews/2015-07-primates")
end
Advantages I see is:
Yes, right. That'll be great. I'll make the modifications.
@oxinabox Any comment on this? I have changed it according to your suggestion. Also I am not very sure about how to set environment variables in AppVeyor, as it is not covered much in their documentation. Should I rather define the env var in all the files than in the CI yml file?
What you've done looks right https://www.appveyor.com/docs/build-configuration/#custom-environment-variables
I have just pushed a commit to your branch which I think fixes A.V config
The A.V failure is the usual one I think
Codecov Report
Continue to review full report at Codecov.