oxinabox / DataDepsGenerators.jl

Utility for developers to help define DataDeps registration blocks, for reusing existing Data with DataDeps.jl
Other
18 stars 6 forks source link

Add Integration Tests #24

Closed SebastinSanty closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    93.8%   93.8%           
======================================
  Files          12      12           
  Lines         210     210           
======================================
  Hits          197     197           
  Misses         13      13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b0a86f...03ba04b. Read the comment docs.

oxinabox commented 6 years ago

What do you think about the idea putting the integration tests in with the reference tests?

E.g.

@testset "BuzzFeedNews (whole repos)" begin

    @testset "Pres Camp" begin
        registration_code = generate(GitHub(), "https://github.com/BuzzFeedNews/presidential-campaign-contributions")

        @testset "Integration Test" begin 
            eval(parse(registration_code)) # evaluate the new code
            @test length(collect(readdir(datadep"Presidential Campaign Contributions"))) > 0
        end

        @test_reference "references/buzzfeed pres-camp.txt" registration_code # See if new code is same as old
    end 

    @test_reference "references/buzzfeed primates.txt" generate(GitHub(), "BuzzFeedNews/2015-07-primates")
end

Advantages I see is:

SebastinSanty commented 6 years ago

Yes, right. That'll be great. I'll make the modifications.

SebastinSanty commented 6 years ago

@oxinabox Any comment on this? I have changed it according to your suggestion. Also I am not very sure about how to set environment variables in AppVeyor, as it is not covered much in their documentation. Should I rather define the env var in all the files than in the CI yml file?

oxinabox commented 6 years ago

What you've done looks right https://www.appveyor.com/docs/build-configuration/#custom-environment-variables

oxinabox commented 6 years ago

I have just pushed a commit to your branch which I think fixes A.V config

oxinabox commented 6 years ago

The A.V failure is the usual one I think