oxinabox / DataDepsGenerators.jl

Utility for developers to help define DataDeps registration blocks, for reusing existing Data with DataDeps.jl

Other

18 stars 6 forks source link

[WIP] Bump to Julia 1.0 #48

Closed SebastinSanty closed 6 years ago

SebastinSanty commented 6 years ago

Gosh, upgrading is so confusing.

oxinabox commented 6 years ago

You'll need to update the CI scripts too, or we can't see anything.

Also you'll need to add Test dependencies on DataDeps and on Test, in the Project.toml.

SebastinSanty commented 6 years ago

Yep, doing that. Following #pkg-usage and #upgradeathon for instructions.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@08d9d77). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage          ?   93.43%           
=========================================
  Files             ?       18           
  Lines             ?      411           
  Branches          ?        0           
=========================================
  Hits              ?      384           
  Misses            ?       27           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08d9d77...61b2574. Read the comment docs.

SebastinSanty commented 6 years ago

Seems like Gumbo doesn't build on Julia 1.0. All other dependencies does.

oxinabox commented 6 years ago

Seems like Gumbo doesn't build on Julia 1.0. All other dependencies does.

We'll have to wait for that then

SebastinSanty commented 6 years ago

What can we do till then? Also, how are you? seems you aren't online much.

oxinabox commented 6 years ago

Til then we can help by fixing Gumbo -- probably not too hard. Also some of the code quality cleanup here, and improving docs. On the docs note I rather liked your final blog post. It was nice to see all the PRs.

I've been away for juliacon, and then some things afterwards.

SebastinSanty commented 6 years ago

Gumbo is already fixed. Issues with other packages like Cascadia.jl and its dependencies. Will look into fixing that.

Yes, I'll push the cleanup part. Also, would you want a formal documentation like readthedocs for DataDeps.jl and DataDepsGenerators.jl? All what exists right now are our blogs, which is often not the best, especially for quick use.

oxinabox commented 6 years ago

I am happy with just stuff being put in Readme.MD I don't think full ReadTheDocs style is useful here.

It is a simple enough package to use.

oxinabox commented 6 years ago

This should now be possible

oxinabox commented 6 years ago

Closing this in favour of #55. I am trying to get Femtocleaner to do the work