search

oxinabox / DataDepsGenerators.jl

Utility for developers to help define DataDeps registration blocks, for reusing existing Data with DataDeps.jl
Other
18 stars 6 forks source link

Delete DataOneV1 #71

Closed oxinabox closed 5 years ago

oxinabox commented 5 years ago

Re https://github.com/oxinabox/DataDepsGenerators.jl/issues/67#issuecomment-432897192

oxinabox commented 5 years ago

the combining failure is because now there is one less generator and the results are different. Semantically they are the same, but since the different providers do things like http vs https for the website that does change the reference. So that needs to be regenerated.

oxinabox commented 5 years ago

while fixing this I noticed that our DataDryad generator wasn't working for DOIs, which I fixed, and added tests.

Also I think this will fail, as I think the DataCite API is down cf: https://twitter.com/oxinabox_frames/status/1056115555499823105 Update: yes indeed it is down.

oxinabox commented 5 years ago

Tests passing. @SebastinSanty do you want to review it?

SebastinSanty commented 5 years ago

Sure, I'll check