fivethirtyeight tests updated

[SebastinSanty]

The tests are working perfectly now. I made some additional changes, which I am not sure if I am correct. I am stating my reasons for the same:

1) I changed the cdn from rawgit.com to raw.githack.com as the tests (and myself) were not able to access the urls returned by generate(Github(), <url>) 2) Though I completely skeptical about this, I removed the get_docfile(GitHub(), mainpage, "LICENSE") as the tests were failing because of this. Naturally so, there weren't any LICENSE file present at the location specified.

[SebastinSanty]

Fixes #8

[oxinabox]

Nice work. It was apparently harder than I thought. Seems like fivethirtyeight has made some changed to their repo files, and now finding the dataset name works on more of them, which is a nice side effect. No doubt some of those changed also relate to why things were more difficult than expected. Good job

re: 1, swapping rawgit to githack is fine. The readme also need to be updated though.

That repo does have a LISCENSE file though, it is at https://github.com/fivethirtyeight/data/blob/master/LICENSE Might need to do some further debugging to workout why that URL is not being found (and/or is not being correctly converted to a githack url).

[codecov-io]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@244f468). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   91.89%           
=========================================
  Files             ?        5           
  Lines             ?       74           
  Branches          ?        0           
=========================================
  Hits              ?       68           
  Misses            ?        6           
  Partials          ?        0

Impacted Files	Coverage Δ
src/GitHub.jl	84.37% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 244f468...c8d7ce4. Read the comment docs.

[SebastinSanty]

I reverted back to rawgit cdn. I think the rawgit server was down yesterday, which is why I was not able to access them. With these changes, everything comes back to normal and this PR is a easy fix as you had said earlier.

[oxinabox]

Nice work.

[oxinabox]

@SebastinSanty have you joined the julia slack? http://slackinvite.julialang.org/ In particular the #jsoc channel?

[SebastinSanty]

Thanks for the leads. I have joined julia slack.