search

oxinabox / MagneticReadHead.jl

A cassette-based debugger | The Other Debugger
MIT License
50 stars 6 forks source link

Pressing Ctrl + D spams iron> in the console #36

Open KristofferC opened 5 years ago

KristofferC commented 5 years ago

iron

oxinabox commented 5 years ago

Can you do versioninfo() for me?

This is the return of https://github.com/oxinabox/MagneticReadHead.jl/issues/13 (which related to https://github.com/JuliaLang/julia/issues/30790) which was closed in https://github.com/oxinabox/MagneticReadHead.jl/pull/15/

KristofferC commented 5 years ago 
julia> versioninfo()
Julia Version 1.1.0
Commit 80516ca202 (2019-01-21 21:24 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, skylake)

I updated to latest master of MagneticReadHead and tried again but same thing.

oxinabox commented 5 years ago

As an aside what did you expect Ctrl+d to do? My instinct says Continue, does that align with yours?

KristofferC commented 5 years ago

I expected it to exit the debugger.

oxinabox commented 5 years ago

But should it keep running the function (Continue) or should it terminate imediately (Abort)

KristofferC commented 5 years ago

I think abort everything and give julia prompt. That was my intention but it doesn't mean it is the best choice :).

oxinabox commented 5 years ago

I think you are right,. It means I am done, e.g. when I press it in julia I exit julia.

oxinabox commented 5 years ago

I can't reproduce this on 


julia> versioninfo()
Julia Version 1.1.0
Commit 80516ca202 (2019-01-21 21:24 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin14.5.0)
  CPU: Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, skylake)

asciicast

You didn't by any chance do something like include(test/runtests.jl) before running it? (A side-effect of how that takes control of readline is when it relinquishes control it doesn't reenable to the protections against this.)