Remove base64 encoding from signature generation

oxipay / oxipay-magento-2.x

GNU General Public License v3.0

7 stars 6 forks source link

Remove base64 encoding from signature generation #19

Closed iugo-josh closed 7 years ago

iugo-josh commented 7 years ago

Change for issue #15

iugo-josh commented 7 years ago

This could be difficult to properly test with issue #17 still open, as a billing state of ACT is hard coded into the fields. Testing with ACT yourself might help.

I have not incremented any version numbers for this yet, as this PR may not be merged straight away. If you are happy with the change, let me know and I'll add a version number bump commit to this PR before you merge it.

sam-flexi commented 7 years ago

Pull request reviewed and approved; new logic identical with what has been implemented in the WooCommerce platform.