search

oxipay / oxipay-magento-2.x

GNU General Public License v3.0
7 stars 6 forks source link

Checkout fixes #23

Closed iugo-josh closed 7 years ago

iugo-josh commented 7 years ago

Changes should fix issues #10, #17, #18 and #22.

This PR was branched from the code in PR #21, so please complete the review of that PR first.

There is an issue with config variable scope in Magento that was fixed in version 2.1.4: https://github.com/magento/magento2/issues/7943 . Please ensure your Magento install has been updated before testing.

iugo-josh commented 7 years ago

I've added a commit to address issue #8. This adds a config field to select allowed checkout countries, so please ensure this is set before testing.

The added field is a built in Magento field that has logic to hide the payment method when a shipping address outside of the selected options is chosen by the customer. This does not seem to be completely foolproof, as it is possible to make the method appear by first selecting an allowed country, then going back to the shipping step and changing the address to a different country. The commit contains additional checks that will pick this up and block the order however.

iugo-josh commented 7 years ago

I've pushed new commits to this PR to merge in the recent config-fixes changes and address the feedback on issue #8. Please see issue #8 for details on how to clear old data that may impact testing of this.

sam-flexi commented 7 years ago

Removing this from the Magento 2 board as this is a reference to a PR and not an issue.