oxiton-foundation / click-metrics

Click Matrics is a powerful URL shortening and analytics platform designed to streamline the process of generating short URLs, creating QR codes, and tracking detailed analytics for each link.
https://click-metrics.vercel.app
MIT License
30 stars 44 forks source link

Theme added #110

Closed Varsani2520 closed 4 months ago

Varsani2520 commented 4 months ago

@oxiton-foundation,

user click on theme button then user able to dark and light mode screen : in light mode: image

in dark mode: image

check it and closed the issue #69

github-actions[bot] commented 4 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our #24. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Varsani2520 commented 4 months ago

Hey @oxiton-foundation , add the label

Varsani2520 commented 4 months ago

Hey @oxiton-foundation, add the label and merged it

Varsani2520 commented 4 months ago

Hey @Swarnendu0123 ,why you closed this issue ?

Varsani2520 commented 4 months ago

i will complaint you in gssoc

Swarnendu0123 commented 4 months ago

We are not accepting this type of PR. You have done unnecessary changes that are not required. We appreciate your enthusiasm, but we can't accept this type of change,

  1. We are using radix-ui, did you ask the maintainers before installing mui?

  2. Look at your changes, you have changed>1000 lines, did you have a proper explanation for it?

We are trying to build something serious, beginners are welcome but we still can't afford this type of activity.

Thanks!

Varsani2520 commented 4 months ago

also anyone admin not tell me about not use mui .... if you said then i create using radix ui

Varsani2520 commented 4 months ago

if you assigned me then claerly told about ,not use external package

rahulpoonia29 commented 4 months ago

Please check the repo before opening a PR. Theme can be implemented in plain tailwind too. Implementing it in Radix would be appreciated because we are already using it.

rahulpoonia29 commented 4 months ago

@Varsani2520 Refer to this https://ui.shadcn.com/docs/dark-mode

Varsani2520 commented 4 months ago

in link as it is like mui ,

Swarnendu0123 commented 4 months ago

We are trying to build the same thing in #96. Let's move on to that PR.