Open sahithinandikula opened 5 months ago
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our #24. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
@Smitkhobragade Generate short link button is not working , so I made the changes in such a way that when input is not provided or empty , it displays message "No URL available to copy". If the URL is generated it displays "URL copied to clipboard"
hey @sahithinandikula . can you do it like. when there is no URL Present in Box. it should not show the copy button. and when there is some URL present then it should become visible. ?
Also can you shift the button on / beside the input box ? something arrangement like this -->
@Smitkhobragade I have made the changes as you mentioned. The button will now be visible only if the URL is generated.
Okay. and what about the button position which I said to shift beside the Input ?
Can you provide a video if possible ? @sahithinandikula
@Smitkhobragade The copy button is displayed only when a valid short URL exists. The input field and copy button are wrapped to ensure proper alignment. Sorry, but I cannot provide with the video because my changes will only be visible if any short URL is generated. Since the GENERATE SHORT link button is not working. I am unable to provide it, hope its okay for you.
You can insert a dummy URL to view it ? if it's okay to attach a photo also it will work, I will then Finalize the PR. @sahithinandikula
I am not able to Guess like how is it looking...
GENERATE SHORT link button is not working. I am unable to provide it, hope its okay for you.
@sahithinandikula you have to start the backend in another terminal, and then you can get the short URL from the backend.
@Swarnendu0123 .
Icon size is too small. Increase the icon size.
@Swarnendu0123 is this okay?
Now it looks good, but can you please increase the width of the Card?
@Swarnendu0123 I hope this is okay!
The UI which you have developed seems like we are copying the source url itself. The copy button should be at the right of the generated url. What do you suggest @Smitkhobragade?
The UI which you have developed seems like we are copying the source url itself. The copy button should be at the right of the generated url. What do you suggest @Smitkhobragade?
Correct @Swarnendu0123 .
It provides a confusion that which url is been copied the generated one. Or the supplied one..
@Smitkhobragade Can I make it as earlier
Copy icon should appear at the right of the generated url. And when the url is already generated, then only we should render the copy button, otherwise we shouldn't render the copy button.
Related Issue(s)
Description
I have asked to add the icon that when clicked copies the URL to the clipboard.
Changes Made
I made the changes in links.tsx file to add an icon that copies the generated URL to the clipboard.
Screenshots (if applicable)
Checklist
Before submitting your pull request, ensure that you have completed the following tasks: