Open Jagpreet153 opened 4 days ago
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our #24. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
@Jagpreet153 can you make a Video of all where you applied the Light and dark Mode ?
In this Photo. the Black Area which I have highlighted using gray pen. can you cover it with the same background. like this kind of doesnt looks nice.
Also this is happening in the next some Screens I have attached.
In the Photo below. The Sidebar looks kind of disconnected. can you manage the color or it so it looks good. make the highlighted area of the same color as of the navbar.
and the last. I think here it is al white. doesn't looks like dark mode. pls solve this also.
@Jagpreet153 . Please Note the above changes and let me know once completed ...
@Jagpreet153 Any Updates ??
I have updated changes
Great it looks good now.
@Swarnendu0123 . I have reviewed the commits. Everything looks fine. You can review and merge it.
The dark mode we are targeting should be dark like GitHub. I don't like e the blue theme. Please change it to dark as github dark mode.
remove the client/package-lock.json
other we can encounter some bug in production.
@Smitkhobragade @Swarnendu0123 Kindly check I have made it to dark theme
Attach video.
In this video, I can see the work is very unstructured. You haven't taken care of borders. The search boxes, the entire Analytics page is white. Also the colour I have talked about is not black, it's a dark grey type colour.
@Swarnendu0123 Ok I will makes the color to dark gray
Related Issue(s)
Description
I have added dark /light mode toggle button
Changes Made
Added mui dependency , changes css of pages files , header.tsx
Screenshots (if applicable)
Checklist
Before submitting your pull request, ensure that you have completed the following tasks:
Additional Notes
Kindly review this PR .