oxiton-foundation / click-metrics

Click Matrics is a powerful URL shortening and analytics platform designed to streamline the process of generating short URLs, creating QR codes, and tracking detailed analytics for each link.
https://click-metrics.vercel.app
MIT License
33 stars 50 forks source link

enhancement: added mode toggle button #196

Open Jagpreet153 opened 4 days ago

Jagpreet153 commented 4 days ago

Related Issue(s)

Description

I have added dark /light mode toggle button

Changes Made

Added mui dependency , changes css of pages files , header.tsx

Screenshots (if applicable)

Screenshot 2024-06-29 165139 image Screenshot 2024-06-29 165211

Checklist

Before submitting your pull request, ensure that you have completed the following tasks:

Additional Notes

Kindly review this PR .

github-actions[bot] commented 4 days ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our #24. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Smitkhobragade commented 4 days ago

@Jagpreet153 can you make a Video of all where you applied the Light and dark Mode ?

Jagpreet153 commented 4 days ago

Sure

https://github.com/oxiton-foundation/click-metrics/assets/119691733/a7235c53-1064-4dbf-b186-08f1d4702573

Smitkhobragade commented 3 days ago

image In this Photo. the Black Area which I have highlighted using gray pen. can you cover it with the same background. like this kind of doesnt looks nice. Also this is happening in the next some Screens I have attached. image image

In the Photo below. The Sidebar looks kind of disconnected. can you manage the color or it so it looks good. make the highlighted area of the same color as of the navbar. image

and the last. I think here it is al white. doesn't looks like dark mode. pls solve this also. image

@Jagpreet153 . Please Note the above changes and let me know once completed ...

Smitkhobragade commented 1 day ago

@Jagpreet153 Any Updates ??

Jagpreet153 commented 1 day ago

I have updated changes Screenshot 2024-07-02 115414 Screenshot 2024-07-02 115508 Screenshot 2024-07-02 115521 Screenshot 2024-07-02 115545 Screenshot 2024-07-02 115603

Smitkhobragade commented 14 hours ago

Great it looks good now.

Smitkhobragade commented 14 hours ago

@Swarnendu0123 . I have reviewed the commits. Everything looks fine. You can review and merge it.

Swarnendu0123 commented 11 hours ago

The dark mode we are targeting should be dark like GitHub. I don't like e the blue theme. Please change it to dark as github dark mode.

Swarnendu0123 commented 11 hours ago

remove the client/package-lock.json other we can encounter some bug in production.

Jagpreet153 commented 8 hours ago

@Smitkhobragade @Swarnendu0123 Kindly check I have made it to dark theme

Swarnendu0123 commented 8 hours ago

Attach video.

Jagpreet153 commented 8 hours ago

https://github.com/oxiton-foundation/click-metrics/assets/119691733/628eec44-73c4-408e-8cfd-e51108832fa8

Swarnendu0123 commented 7 hours ago

https://github.com/oxiton-foundation/click-metrics/assets/119691733/628eec44-73c4-408e-8cfd-e51108832fa8

In this video, I can see the work is very unstructured. You haven't taken care of borders. The search boxes, the entire Analytics page is white. Also the colour I have talked about is not black, it's a dark grey type colour.

Jagpreet153 commented 6 hours ago

@Swarnendu0123 Ok I will makes the color to dark gray