Closed Adamtaranto closed 2 months ago
Feel free to add any code comments, I'm still new to Rust conventions.
What do you think of the function name get_hash_array()
- is it confusing that it actually returns a list?
Happy to be a maintainer on PyPi and conda-forge.
Sure, I think this is self-contained enough for a release. Unless you want to wait until wheel issue #15 is fixed.
Also, should I add a get_array()
function for symmetry between the kmer/hash get functions?
i.e. to return counts for an ordered list of kmers.
I've added support for set operations on KmerHashTable objects.
I'm very new to Rust, but the test cases I've written are passing. Review with caution!
Summary of changes:
count_hash()
method so only does one hashmap lookupget_hash()
to query kmer counts using hash key. Returns zero if missing key.get_hash_array()
to lookup many hash keys at once, takes list of keys, returns list of values. Returns zero for missing keys..hashes
attribute as per sourmash, returns list of all keys in table