oxli-bio / oxli

k-mers and the like
BSD 3-Clause "New" or "Revised" License
15 stars 0 forks source link

WIP: Combine KmerCountTables with Add() #73

Open Adamtaranto opened 1 month ago

Adamtaranto commented 1 month ago

Closes #62

Adamtaranto commented 1 month ago

Not sold on having a subtract method, might get rid of it.

Adamtaranto commented 1 month ago

Ditched the subtract function.

Need to decide if we should allow adding a table to itself - this creates issues around borrowing the same object multiple times and is generally a bit of a pain.

Maybe just raise error if trying to add table to itself?

Adamtaranto commented 1 month ago

I'm giving up on trying to check if self and other are the same table. Just let it die with borrow error.

ctb commented 3 weeks ago

hah! over in https://github.com/oxli-bio/oxli/pull/83 I created a _merge method that does the same thing. let me look...

ctb commented 3 weeks ago

I am wondering if we want to avoid doing merges in parallel fashion? The locking is going to add a lot of overhead I think.

Adamtaranto commented 2 days ago

Should I fully remove parallelisation from the function?