search

oxoooo / earth

https://play.google.com/store/apps/details?id=ooo.oxo.apps.earth
GNU General Public License v3.0
280 stars 37 forks source link

added french translation #3

Closed ghost closed 8 years ago

xingrz commented 8 years ago

Thank you very much!

I'll review and merge it as soon as possible.

ghost commented 8 years ago

You're welcome and thanks to you for this beautiful live wallpaper!

xingrz commented 8 years ago

Hi @M2ck , sorry I'm late. I just cleaned up and pushed the latest code. Would you please update the translation?

ghost commented 8 years ago

Hi @xingrz, don't worry, better late than never :)

Done! I've improved a few old strings and updated the new ones.

xingrz commented 8 years ago

Great!

Would you please rebase your patch to the latest master base?

git checkout patch-1
git remote add upstream https://github.com/oxoooo/earth.git
git pull --rebase upstream master
git push origin patch-1 -f
ghost commented 8 years ago

Sorry I'm using GitHub only via my browser for translation I'm not developer at all.

How proceed? Close this PR and open a new one could be a good workaround for you?

Sorry again, I'm feel dumb...^^'

xingrz commented 8 years ago

Don't worry @M2ck . Instead I can do this for you. But in that way this PR will not turn Merged but Closed. It's a general way.

xingrz commented 8 years ago

Done. Rebased as a7c869f6474dc79450f1d344c9eef993a4730b66 and merged.

ghost commented 8 years ago

Perfect, thanks!