Issue in TYPESCRIPT-ES when using mega-lint-runner

[MRDGH2821]

Describe the bug

When using mega-lint-runner, TYPESCRIPT_ES always fails to lint, because it is not able to access /tsconfig.json

Where as in Github Actions, there is no error for the same.

Expected behavior TYPESCRIPT_ES should have thrown error or success flag on both CI & local, but it is not happenning.

Screenshots Here is the log file instead

ERROR-TYPESCRIPT_ES.log

Additional context My repository where it is enabled - https://github.com/MRDGH2821/Perpetual-Mechanical-Array-Bot/tree/rewrite-detritus-bug-hunt Branch - rewrite-detritus-bug-hunt The configurations are at root of the directory.

.eslintrc.json -

{
  "extends": ["eslint-config-airbnb-base", "eslint-config-airbnb-typescript/base"],
  "parserOptions": {
    "project": ["tsconfig.json", "tsconfig.eslint.json"]
  },
  "rules": {
    "no-console": "off"
  }
}

tsconfig.json -

{
  "compilerOptions": {
    "allowJs": false,
    "baseUrl": "./src",
    "declaration": true,
    "esModuleInterop": true,
    "experimentalDecorators": true,
    "importHelpers": true,
    "inlineSources": true,
    "lib": ["ES2019", "DOM", "ESNext"],
    "module": "CommonJS",
    "moduleResolution": "node",
    "noImplicitAny": true,
    "noImplicitReturns": true,
    "outDir": "out",
    "sourceMap": true,
    "strict": true,
    "strictNullChecks": true,
    "target": "ESNext",
    "resolveJsonModule": true,
    "watch": false
  },
  "ts-node": {
    "require": ["tsconfig-paths/register"],
    "swc": true
  },
  "tsc-alias": {
    "resolveFullPaths": true
  },
  "include": ["src/**/*.ts"],
  "exclude": ["node_modules", ".vscode", "./old-src", "./out/*"]
}

[Kurt-von-Laven]

This is a stab in the dark, but what happens if you remove the PRE_COMMANDS, POST_COMMANDS, and/or DEFAULT_WORKSPACE from your MegaLinter config?

I'm not sure whether or not this will be helpful to you, but perhaps it will be helpful to others. I haven't run into this issue in our TypeScript projects, because we use Prettier. See ScribeMD/docker-cache for an example of a working MegaLinter + TypeScript config.

[MRDGH2821]

PRE_COMMANDS was to install the eslint plugins & Airbnb config POST_COMMANDS was because I couldn't find how to make specific linters fix the code after a specific linter is done fixing (i.e. I want prettier to fix first, then eslint to fix next. Mega linter didn't give expected results, thus put npm script in post commmands)

Anyways, I did the following -

Case 1

ESlint config

{
  "extends": ["eslint-config-airbnb-base", "eslint-config-airbnb-typescript/base"],
  "parserOptions": {
    "project": ["./tsconfig.json", "./tsconfig.eslint.json"]
  },
  "rules": {
    "no-console": "off"
  }
}

Mega linter config

# Configuration file for MegaLinter
# See all available variables at https://megalinter.github.io/configuration/ and in linters documentation

APPLY_FIXES: all # all, none, or list of linter keys
# ENABLE: # If you use ENABLE variable, all other languages/formats/tooling-formats will be disabled by default
# ENABLE_LINTERS: # If you use ENABLE_LINTERS variable, all other linters will be disabled by default
DISABLE:
  - GIT
# - COPYPASTE # Uncomment to disable checks of excessive copy-pastes
# - SPELL # Uncomment to disable checks of spelling mistakes
DISABLE_LINTERS:
  - JAVASCRIPT_STANDARD
  - TYPESCRIPT_STANDARD
SHOW_ELAPSED_TIME: true
FILEIO_REPORTER: false
# DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass
JAVASCRIPT_DEFAULT_STYLE: prettier
TYPESCRIPT_DEFAULT_STYLE: prettier
LINTER_RULES_PATH: .
PRINT_ALPACA: false

PRE_COMMANDS:
  - command: 'npm install'
    cwd: 'workspace'
POST_COMMANDS:
  - command: 'npm run pretty'
    cwd: 'workspace'
IGNORE_GITIGNORED_FILES: true

# Excludes cspell file itself
SPELL_MISSPELL_FILTER_REGEX_EXCLUDE: cspell.

Result

TYPESCRIPT_ES fails on local, success on Github Action

Log file shows same error text as attached in the first comment of the issue.

Case 2:

ESlint config

Same as in Case 1

Mega linter

# Configuration file for MegaLinter
# See all available variables at https://megalinter.github.io/configuration/ and in linters documentation

APPLY_FIXES: all # all, none, or list of linter keys
# ENABLE: # If you use ENABLE variable, all other languages/formats/tooling-formats will be disabled by default
# ENABLE_LINTERS: # If you use ENABLE_LINTERS variable, all other linters will be disabled by default
DISABLE:
  - GIT
# - COPYPASTE # Uncomment to disable checks of excessive copy-pastes
# - SPELL # Uncomment to disable checks of spelling mistakes
DISABLE_LINTERS:
  - JAVASCRIPT_STANDARD
  - TYPESCRIPT_STANDARD
SHOW_ELAPSED_TIME: true
FILEIO_REPORTER: false
# DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass
JAVASCRIPT_DEFAULT_STYLE: prettier
TYPESCRIPT_DEFAULT_STYLE: prettier
LINTER_RULES_PATH: .
PRINT_ALPACA: false

#PRE_COMMANDS:
#  - command: 'npm install'
#    cwd: 'workspace'
#POST_COMMANDS:
#  - command: 'npm run pretty'
#    cwd: 'workspace'
IGNORE_GITIGNORED_FILES: true

# Excludes cspell file itself
SPELL_MISSPELL_FILTER_REGEX_EXCLUDE: cspell.

Result

Same as Case 1 + There are git diffs in some files, because ESlint couldn't "fix" them

Case 3

ESlint config

{
  "extends": ["eslint-config-airbnb-base", "eslint-config-airbnb-typescript/base"],
  "parserOptions": {
    "project": ["tsconfig.json", "tsconfig.eslint.json"]
  },
  "rules": {
    "no-console": "off"
  }
}

Mega linter config

Same as Case 2

Result

Same as Case 2

Verdict

Even after removing PRE_COMMANDS, POST_COMMANDS & DEFAULT_DIRECTORY ; TYPESCRIPT_ES fails because in eslint config it is supposed to extend tsconfig.json which actually exists in the root of project directory (same place as eslint config) but cannot find /tsconfig.json

I wonder if the issue is about that / (slash) in /tsconfig.json which logs say

[MRDGH2821]

Forgot to mention this -

$ docker --version
Docker version 20.10.16, build aa7e414

$  docker-compose --version
docker-compose version 1.29.2, build 5becea4c

I'm using Windows 11 pro, Docker is using WSL 2.

The issue affects me locally only, so I'm fine if no definite solution is found as long as it works properly as Github Action

[Kurt-von-Laven]

Now I'm doubly glad you filed this bug, because I just realized that we haven't been running ESLint at all, which explains why we didn't experience this issue. (We don't use the GitHub Action.) When I create a .eslintrc.yaml, ESLint no longer gets skipped, and I am able to reproduce this issue locally. Users who aren't using any rules that require parserServices to be generated can avoid this issue entirely by deleting parserOptions.project from their ESLint config. For those who are, prefixing each path in parserOptions.project with /tmp/lint appears to be a hacky, short-term workaround locally. I'm guessing you'll probably also have to add the following to your MegaLinter config:

TYPESCRIPT_ES_PRE_COMMANDS:
  - command: npm install <missing dependencies, such as your base tsconfig>

Setting DEFAULT_WORKSPACE in the MegaLinter config has no effect on the bug.

On a side note, if I understood correctly, you are saying that ESLint and Prettier are configured in such a manner that they potentially contradict each other, which sounds problematic. Please see Prettier's guidance on playing nicely with ESLint. You can also configure many editors to run many linters on save.

I do think this issue needs to be fixed, and I'm making it my current active work item because the present work around is so unacceptable long-term.

[Kurt-von-Laven]

@MRDGH2821, we still need to fix the underlying bug, but hopefully this improved workaround gets you unblocked for the time being. I recommend adding the following to your MegaLinter config:

TYPESCRIPT_ES_CLI_LINT_MODE: project

This causes ESLint to be run on the entire project rather than be passed each individual file, so if your project has a lot of files, this will unfortunately slow things down. You probably won't even need to use TYPESCRIPT_ES_PRE_COMMANDS.

When I run ESLint outside of MegaLinter in the same project, I don't experience the same issue, so I am pretty confident this is our bug. I debugged this issue by passing --env LOG_LEVEL=DEBUG to mega-linter-runner and noting the following output in the logs:

[eslint] command: ['eslint', '--no-ignore', '--fix', '/tmp/lint/file1.ts', '/tmp/lint/file2.ts', ...]
[eslint] CWD: /

With the lint mode overridden from the default of list_of_files to project, I instead see:

[eslint] command: ['eslint', '--no-ignore', '--fix']
[eslint] CWD: /tmp/lint
[eslint] result: 0 

This, in conjunction with the error you initially reported, implies that ESLint is not run with the correct working directory in list_of_files mode. @nvuillam may have some insights on how we can fix this issue for all our users after the v6 release. Also, bravo for including the current working directory in the debug logs as that greatly reduced my debugging time. What a forward-thinking decision :).

[MRDGH2821]

On a side note, if I understood correctly, you are saying that ESLint and Prettier are configured in such a manner that they potentially contradict each other, which sounds problematic.

The code formatted by prettier triggers eslint errors. It manages to touch all the code (which ESlint doesn't somehow) but even after multiple modifications to the config, I couldn't get any config which didn't trigger eslint errors. So I run eslint fix after prettier. And the output from eslint also looks good. Hence the post commands (prettier fixes then eslint fixes)

Adding this line into the config worked for me in local & github action both.

TYPESCRIPT_ES_CLI_LINT_MODE: project

This causes ESLint to be run on the entire project rather than be passed each individual file, so if your project has a lot of files, this will unfortunately slow things down.

If there's a way to utilise multiple CPU cores then I would like to know. Else slow speed not much of an issue. On top of that I won't be linting the files when the code goes live in production 😂

Thanks for the temporary fix! Looking forward to v6

[Kurt-von-Laven]

Sorry I overlooked your lingering question here. Unfortunately, beyond that you upvote eslint/eslint#3565, I don't have a great suggestion for you. @nvuillam may correct me if I am mistaken, but my understanding is that MegaLinter runs the linter once in project mode by definition and can only run a linter multiple times in files or list_of_files modes. Linters that themselves support parallelization can be run in parallel in project mode by MegaLinter provided any necessary additional arguments are passed to the underlying linter. Ha ha, I am glad the performance is not a major issue for you at the moment.

[nvuillam]

That brings us back to https://github.com/oxsecurity/megalinter/issues/1544 :) I'll try to make a doc page today :)

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

[Kurt-von-Laven]

I think this issue : ESLint :: #440 : Swiftlint.

[Gainutdinov]

Hello, face the same issue with TYPESCRIPT_ES above, the workaround doesn't help, well issue is gone and it seems that .ts_config is there any improvements? I use gitlab and my config is pretty basic but TYPESCRIPT_ES doesn't catch any errors. Maybe I am doing something wrong.

linter:
  stage: pre-build
  image:
    name: oxsecurity/megalinter:v6
  script: [ "true" ]
  variables:
    DEFAULT_WORKSPACE: "/builds/project/project/src/frontend"

---
ENABLE: 
  - "TYPESCRIPT"
ENABLE_LINTERS:
  - "TYPESCRIPT_ES"
  - "TYPESCRIPT_PRETTIER"
JAVASCRIPT_DEFAULT_STYLE: "prettier"
TYPESCRIPT_DEFAULT_STYLE: "prettier"
TYPESCRIPT_ES_RULES_PATH: "/builds/project/project/src/frontend"
TYPESCRIPT_ES_CLI_LINT_MODE: project
TYPESCRIPT_ES_PRE_COMMANDS: 
  - command: npm install eslint-plugin-rxjs@latest eslint-plugin-rxjs-angular@latest
    cwd: "workspace"
SHOW_ELAPSED_TIME: true
...

[Kurt-von-Laven]

Do you have a .eslintrc.yaml? Some linters are configured only to run when certain files they rely on are present.

[Gainutdinov]

Yeah sure, initially we used .eslintrc as config file for eslint but this type of file wasn't recognized by linter even when I provided corresponding environment variable and TYPESCRIPT_ES was always inactive because of this I renamed file to .eslintrc.json and the linter successfully passed initialization and became active but failed with error mentioned above: /.tsconfig.json not found, so I added PRE_COMMANDS:.. which copies src/frontend/* files into /. Last step helped me to overcome issue with not founded .tsconfig.json but still it seems that it doesn't use the provided config file cause I see more errors in comparison with local linter.

[Kurt-von-Laven]

Thank you for confirming; in retrospect that should have been obvious, but I am doing a bit too much context switching right now. This doesn't solve your problem, but TYPESCRIPT_ES_CONFIG_FILE defaults to .eslintrc.json and can be overridden if you desire. I tend to set *_CONFIG_FILE to LINTER_DEFAULT personally as I find this behavior most intuitive. Are you at liberty to share the contents of your .eslintrc.json? Ours that is working at MegaLinter v6.19.0 is quite minimal, so maybe you will spot something in there that you can copy.

[Gainutdinov]

Thank you for the quick response, just want to mention that I tried to use TYPESCRIPT_ES_CONFIG_FILE but it didn't help and on initialization step I still saw that TYPESCRIPT_ES linter skipped. Regarding the config, I think I can send the config, I will send it a bit later when will be near the computer.

[Gainutdinov]

.eslintrc.json file:

{
  "root": true,
  "parser": "@typescript-eslint/parser",
  "ignorePatterns": ["**/jest.config.ts", "**/jest.preset.ts", "**/custom.d.ts"],
  "plugins": [
    "@typescript-eslint",
    "rxjs",
    "rxjs-angular"
  ],
  "parserOptions": {
    "project": "tsconfig.json"
  },
  "extends": [
  ],
  "rules": {
    // basic rules
    "prefer-const": "error",
    "rxjs-angular/prefer-takeuntil": [
      "error",
      {
        "alias": ["untilDestroyed"],
        "checkComplete": true,
        "checkDecorators": ["Component"]
      }
   ],
    "@typescript-eslint/no-useless-constructor": "error",
    "max-lines-per-function": ["error", { "max": 35 }],
    "no-param-reassign": "error",
    "indent": ["error", 2, {"SwitchCase": 1}],
    "semi": ["error", "always", { "omitLastInOneLineBlock": true}],
    "no-template-curly-in-string": "error",
    "prefer-template": "error",
    "@typescript-eslint/explicit-member-accessibility": [
      "error",
      {
        "accessibility": "no-public"
      }
    ],
    "@typescript-eslint/no-extraneous-class": ["error", {
      "allowWithDecorator": true
    }],
    "@typescript-eslint/no-this-alias": [
      "error",
      {
        "allowDestructuring": false
      }
    ],
    // typescript strict null check required
    "@typescript-eslint/strict-boolean-expressions": "error",
    "@typescript-eslint/explicit-function-return-type": ["error"],
    "@typescript-eslint/consistent-type-assertions": [
      "error",
      {
        "assertionStyle": "never"
      }
    ],
    "@typescript-eslint/no-non-null-assertion": "warn",
    "@typescript-eslint/naming-convention": [
      "error",
      {
        "selector": "default",
        "format": ["camelCase"],
        "leadingUnderscore": "allow",
        "trailingUnderscore": "forbid"
      },
      {
        "selector": "variable",
        "format": ["camelCase", "UPPER_CASE"],
        "leadingUnderscore": "allow",
        "trailingUnderscore": "forbid"
      },
      {
        "selector": "variable",
        "modifiers": ["destructured"],
        "format": null
      },
      {
        "selector": "typeProperty",
        "format": ["camelCase", "PascalCase", "UPPER_CASE"]
      },
      {
        "selector": "objectLiteralProperty",
        "format": null
      },
      {
        "selector": ["typeLike", "enumMember"],
        "format": ["PascalCase"]
      }
    ],

    // compact - better reading
    "max-len": [
      "error",
      {
        "code": 120,
        "ignoreUrls": true,
        "ignoreStrings": true
      }
    ],
    "max-lines": ["error", 500],
    "@typescript-eslint/type-annotation-spacing": "error",
    "@typescript-eslint/typedef": [
      "error",
      {
        "variableDeclaration": true,
        "objectDestructuring": true,
        "variableDeclarationIgnoreFunction": true
      }
    ],

    // clear trash
    "no-trailing-spaces": "error",
    "@typescript-eslint/no-unused-expressions": "error",
    "@typescript-eslint/no-extra-non-null-assertion": "error",
    "@typescript-eslint/no-empty-interface": [
      "error",
      {
        "allowSingleExtends": false
      }
    ],
    "@typescript-eslint/no-explicit-any": "error",
    "@typescript-eslint/no-confusing-non-null-assertion": "warn",
    "no-duplicate-case": "error",
    "no-duplicate-imports": "error",
    "no-console": "error",
    "no-empty": "error",
    "no-sequences": "error",
    "no-sparse-arrays": "error"
  }
}

[Kurt-von-Laven]

Thanks; that's helpful, but unfortunately I have more questions than answers for you. The original error was Parsing error: Cannot read file '/tsconfig.json', but can you confirm that yours is Parsing error: Cannot read file '/.tsconfig.json'? I ask because your parserOptions.parser is tsconfig.json without the leading .. Do you have a megalinter-reports/linters_logs/*-TYPESCRIPT_ES.log after running MegaLinter? Are you able to share your package.json?

On a side note, I suspect you should have env.browser and env.jest set to true.

[Gainutdinov]

package.json

{
  "name": "project-frontend",
  "license": "MIT",
  "scripts": {
    "dep-graph": "nx dep-graph",
    "start:prod": "nx run project:serve:development --proxyConfig=tools/proxies/prod.json --live-reload",
    "start:dev1": "nx run project:serve:development --proxyConfig=tools/proxies/dev1.json --live-reload",
    "start:demo2": "nx run project:serve:development --proxyConfig=tools/proxies/demo2.json --live-reload",
    "postinstall": "node ./decorate-angular-cli.js && ngcc --properties es2015 browser module main",
    "build": "nx build --deploy-url=/tasks/ --base-href=/tasks/",
    "test": "nx test",
    "ng": "nx",
    "lint": "eslint . --ext .ts",
    "prettier:check-diff": "prettier --config .prettierrc.json -c $(git diff HEAD --relative --name-only --diff-filter d | grep -E './**/*.(html|ts)' | xargs) --ignore-unknown",
    "prettier:fix-diff": "prettier --config .prettierrc.json -w $(git diff HEAD --relative --name-only --diff-filter d | grep -E './**/*.(html|ts)' | xargs) --ignore-unknown",
    "prettier:check-all": "prettier --config .prettierrc.json -c ./**/*.ts ./**/*.html --ignore-unknown",
    "prettier:fix-all": "prettier --config .prettierrc.json -w ./**/*.ts ./**/*.html --ignore-unknown",
    "start:production": "nx run project:serve:production"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "13.3.8",
    "@angular/cdk": "13.3.7",
    "@angular/common": "13.3.8",
    "@angular/compiler": "13.3.8",
    "@angular/core": "13.3.8",
    "@angular/forms": "13.3.8",
    "@angular/platform-browser": "13.3.8",
    "@angular/platform-browser-dynamic": "13.3.8",
    "@angular/router": "13.3.8",
    "@ant-design/icons": "^4.7.0",
    "@ant-design/icons-angular": "^13.1.0",
    "@auth0/angular-jwt": "~5.0.2",
    "@frontend-libs/cdk": "2.0.4",
    "@frontend-libs/functions": "~2.0.1",
    "@frontend-libs/kit": "2.0.2",
    "@frontend-libs/pipes": "2.0.2",
    "@frontend-libs/redesign-kit": "0.0.53",
    "@ngneat/hot-toast": "4.1.0",
    "@ngneat/transloco": "2.23.2",
    "@ngneat/until-destroy": "~9.2.0",
    "@ngxs/store": "^3.7.3-dev.master-b00eeb3",
    "@nrwl/angular": "^14.5.6",
    "@tiptap/extension-blockquote": "^2.0.0-beta.209",
    "@tiptap/extension-bold": "^2.0.0-beta.209",
    "@tiptap/extension-bullet-list": "^2.0.0-beta.209",
    "@tiptap/extension-character-count": "^2.0.0-beta.26",
    "@tiptap/extension-code": "^2.0.0-beta.199",
    "@tiptap/extension-code-block-lowlight": "^2.0.0-beta.199",
    "@tiptap/extension-color": "^2.0.0-beta.9",
    "@tiptap/extension-document": "^2.0.0-beta.209",
    "@tiptap/extension-dropcursor": "^2.0.0-beta.209",
    "@tiptap/extension-gapcursor": "^2.0.0-beta.209",
    "@tiptap/extension-hard-break": "^2.0.0-beta.209",
    "@tiptap/extension-heading": "^2.0.0-beta.209",
    "@tiptap/extension-history": "^2.0.0-beta.209",
    "@tiptap/extension-horizontal-rule": "^2.0.0-beta.209",
    "@tiptap/extension-image": "^2.0.0-beta.27",
    "@tiptap/extension-italic": "^2.0.0-beta.209",
    "@tiptap/extension-link": "^2.0.0-beta.38",
    "@tiptap/extension-list-item": "^2.0.0-beta.209",
    "@tiptap/extension-ordered-list": "^2.0.0-beta.209",
    "@tiptap/extension-paragraph": "^2.0.0-beta.209",
    "@tiptap/extension-placeholder": "^2.0.0-beta.209",
    "@tiptap/extension-strike": "^2.0.0-beta.209",
    "@tiptap/extension-subscript": "^2.0.0-beta.10",
    "@tiptap/extension-superscript": "^2.0.0-beta.10",
    "@tiptap/extension-table": "^2.0.0-beta.49",
    "@tiptap/extension-table-cell": "^2.0.0-beta.20",
    "@tiptap/extension-table-header": "^2.0.0-beta.22",
    "@tiptap/extension-table-row": "^2.0.0-beta.19",
    "@tiptap/extension-task-item": "^2.0.0-beta.199",
    "@tiptap/extension-task-list": "^2.0.0-beta.199",
    "@tiptap/extension-text": "^2.0.0-beta.209",
    "@tiptap/extension-text-align": "^2.0.0-beta.29",
    "@tiptap/extension-text-style": "^2.0.0-beta.23",
    "@tiptap/extension-typography": "^2.0.0-beta.20",
    "@tiptap/extension-underline": "^2.0.0-beta.23",
    "@typescript-eslint/parser": "^5.18.0",
    "lowlight": "^2.7.0",
    "ng-zorro-antd": "~13.3.2",
    "ngx-scrollbar": "^8.0.0",
    "ngx-tippy-wrapper": "^5.0.2",
    "ngx-tiptap": "^5.0.0",
    "npx": "^10.2.2",
    "rxjs": "^7.5.5",
    "tslib": "~2.3.1",
    "turndown": "^7.1.1",
    "uuid": "^8.3.2",
    "zone.js": "0.11.5"
  },
  "devDependencies": {
    "@angular-builders/custom-webpack": "~13.1.0",
    "@angular-devkit/build-angular": "13.3.5",
    "@angular-eslint/builder": "~13.2.1",
    "@angular-eslint/eslint-plugin": "~13.2.1",
    "@angular-eslint/eslint-plugin-template": "~13.2.1",
    "@angular-eslint/schematics": "~13.2.1",
    "@angular-eslint/template-parser": "~13.2.1",
    "@angular/cli": "13.3.5",
    "@angular/compiler-cli": "13.3.8",
    "@angular/language-service": "13.3.8",
    "@ngxs/devtools-plugin": "^3.7.4",
    "@nrwl/cli": "^14.5.6",
    "@nrwl/cypress": "^14.5.6",
    "@nrwl/eslint-plugin-nx": "^14.5.6",
    "@nrwl/jest": "^14.5.6",
    "@nrwl/linter": "^14.5.6",
    "@nrwl/workspace": "^14.5.6",
    "@types/jest": "27.4.1",
    "@types/node": "16.11.7",
    "@types/turndown": "^5.0.1",
    "@types/uuid": "^8.3.4",
    "@typescript-eslint/eslint-plugin": "~5.18.0",
    "cypress": "^9.1.0",
    "eslint": "~8.12.0",
    "eslint-config-prettier": "8.1.0",
    "eslint-plugin-cypress": "^2.10.3",
    "eslint-plugin-import": "^2.26.0",
    "eslint-plugin-jest": "^26.4.6",
    "eslint-plugin-jsdoc": "^39.3.2",
    "eslint-plugin-prefer-arrow": "^1.2.3",
    "eslint-plugin-rxjs": "^5.0.2",
    "eslint-plugin-rxjs-angular": "^2.0.0",
    "eslint-plugin-unicorn": "^42.0.0",
    "file-loader": "^6.2.0",
    "jest": "27.5.1",
    "jest-preset-angular": "11.1.1",
    "nx": "^14.1.4",
    "prettier": "^2.7.1",
    "raw-loader": "~4.0.2",
    "ts-jest": "27.1.4",
    "ts-node": "~10.4.0",
    "typescript": "^4.6.4",
    "typescript-strict-plugin": "^2.0.0"
  }
}

[Gainutdinov]

----------------------------------------------------------------------------------------------------
------------------------------------ MegaLinter, by OX Security ------------------------------------
----------------------------------------------------------------------------------------------------
 - Image Creation Date: 2023-02-05T11:57:24Z
 - Image Revision: f8d535e
 - Image Version: 1.28.0
----------------------------------------------------------------------------------------------------
The MegaLinter documentation can be found at:
 - https://megalinter.io/1.28.0
----------------------------------------------------------------------------------------------------
section_start:`1678000190220630554`:megalinter-init[collapsed=true]
MegaLinter initialization (expand for details)

MARKDOWN_REMARK_LINT has been temporary disabled in MegaLinter, please use a previous MegaLinter version or wait for the next one !
Skipped linters: ACTION_ACTIONLINT, ANSIBLE_ANSIBLE_LINT, ARM_ARM_TTK, BASH_EXEC, BASH_SHELLCHECK, BASH_SHFMT, BICEP_BICEP_LINTER, CLOJURE_CLJ_KONDO, CLOUDFORMATION_CFN_LINT, COFFEE_COFFEELINT, COPYPASTE_JSCPD, CPP_CPPLINT, CSHARP_CSHARPIER, CSHARP_DOTNET_FORMAT, CSS_SCSS_LINT, CSS_STYLELINT, C_CPPLINT, DART_DARTANALYZER, DOCKERFILE_HADOLINT, EDITORCONFIG_EDITORCONFIG_CHECKER, ENV_DOTENV_LINTER, GHERKIN_GHERKIN_LINT, GO_GOLANGCI_LINT, GO_REVIVE, GRAPHQL_GRAPHQL_SCHEMA_LINTER, GROOVY_NPM_GROOVY_LINT, HTML_DJLINT, HTML_HTMLHINT, JAVASCRIPT_ES, JAVASCRIPT_PRETTIER, JAVASCRIPT_STANDARD, JAVA_CHECKSTYLE, JAVA_PMD, JSON_ESLINT_PLUGIN_JSONC, JSON_JSONLINT, JSON_NPM_PACKAGE_JSON_LINT, JSON_PRETTIER, JSON_V8R, JSX_ESLINT, KOTLIN_KTLINT, KUBERNETES_KUBECONFORM, KUBERNETES_KUBEVAL, LATEX_CHKTEX, LUA_LUACHECK, MAKEFILE_CHECKMAKE, MARKDOWN_MARKDOWNLINT, MARKDOWN_MARKDOWN_LINK_CHECK, MARKDOWN_MARKDOWN_TABLE_FORMATTER, MARKDOWN_REMARK_LINT, OPENAPI_SPECTRAL, PERL_PERLCRITIC, PHP_PHPCS, PHP_PHPLINT, PHP_PHPSTAN, PHP_PSALM, POWERSHELL_POWERSHELL, POWERSHELL_POWERSHELL_FORMATTER, PROTOBUF_PROTOLINT, PUPPET_PUPPET_LINT, PYTHON_BANDIT, PYTHON_BLACK, PYTHON_FLAKE8, PYTHON_ISORT, PYTHON_MYPY, PYTHON_PYLINT, PYTHON_PYRIGHT, RAKU_RAKU, REPOSITORY_CHECKOV, REPOSITORY_DEVSKIM, REPOSITORY_DUSTILOCK, REPOSITORY_GITLEAKS, REPOSITORY_GIT_DIFF, REPOSITORY_GOODCHECK, REPOSITORY_SECRETLINT, REPOSITORY_SEMGREP, REPOSITORY_SYFT, REPOSITORY_TRIVY, RST_RSTCHECK, RST_RSTFMT, RST_RST_LINT, RUBY_RUBOCOP, RUST_CLIPPY, R_LINTR, SALESFORCE_SFDX_SCANNER_APEX, SALESFORCE_SFDX_SCANNER_AURA, SALESFORCE_SFDX_SCANNER_LWC, SCALA_SCALAFIX, SNAKEMAKE_LINT, SNAKEMAKE_SNAKEFMT, SPELL_CSPELL, SPELL_MISSPELL, SPELL_PROSELINT, SQL_SQLFLUFF, SQL_SQL_LINT, SQL_TSQLLINT, SWIFT_SWIFTLINT, TEKTON_TEKTON_LINT, TERRAFORM_CHECKOV, TERRAFORM_KICS, TERRAFORM_TERRAFORM_FMT, TERRAFORM_TERRAGRUNT, TERRAFORM_TERRASCAN, TERRAFORM_TFLINT, TSX_ESLINT, TYPESCRIPT_STANDARD, VBDOTNET_DOTNET_FORMAT, XML_XMLLINT, YAML_PRETTIER, YAML_V8R, YAML_YAMLLINT
To receive reports as email, please set variable EMAIL_REPORTER_EMAIL
section_end:`1678000191111898605`:megalinter-init

section_start:`1678000191111954200`:megalinter-file-listing[collapsed=true]
MegaLinter now collects the files to analyse (expand for details)
Listing all files in directory [/builds/project/project/src/frontend], then filter with:
- File extensions: .ts
Unable to list git ignored files ()
Kept [724] files on [1318] found files

+----MATCHING LINTERS---+----------+----------------+------------+
| Descriptor | Linter   | Criteria | Matching files | Format/Fix |
+------------+----------+----------+----------------+------------+
| TYPESCRIPT | eslint   | .ts      | 724            | no         |
| TYPESCRIPT | prettier | .ts      | 724            | no         |
+------------+----------+----------+----------------+------------+
section_end:`1678000191164593432`:megalinter-file-listing

section_start:`1678000199307910847`:processed-TYPESCRIPT_PRETTIER[collapsed=true]
✅ Linted [TYPESCRIPT] files with [prettier]: Found 1 non blocking error(s) - (7.85s) (expand for details)
- Using [prettier v2.8.3] https://megalinter.io/1.28.0/descriptors/typescript_prettier
- MegaLinter key: [TYPESCRIPT_PRETTIER]
- Rules config: [/builds/project/project/src/frontend/.prettierrc.json]
- Number of files analyzed: [724]
--Error detail:
Checking formatting...
[warn] builds/project/project/src/frontend/libs/shared/src/lib/types/type-color.type.ts
[warn] Code style issues found in the above file. Forgot to run Prettier?

section_end:`1678000199311338660`:processed-TYPESCRIPT_PRETTIER

section_start:`1678000239139554091`:processed-TYPESCRIPT_ES[collapsed=true]
❌ Linted [TYPESCRIPT] files with [eslint]: Found 724 error(s) - (47.67s) (expand for details)
- Using [eslint v8.33.0] https://megalinter.io/1.28.0/descriptors/typescript_eslint
- MegaLinter key: [TYPESCRIPT_ES]
- Rules config: [/builds/project/project/src/frontend/.eslintrc.json]
- Ignore file: [/builds/project/project/src/frontend/.eslintignore]
- Number of files analyzed: [724]
[Pre][TYPESCRIPT_ES] run: [cd /node-deps && npm install eslint-plugin-rxjs@latest eslint-plugin-rxjs-angular@latest] in cwd [/builds/project/project/src/frontend]
[Pre][TYPESCRIPT_ES] 
added 38 packages, removed 2 packages, changed 2 packages, and audited 2359 packages in 14s

234 packages are looking for funding
  run `npm fund` for details

15 vulnerabilities (2 moderate, 12 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

--Error detail:

/builds/project/project/src/frontend/apps/project/jest.config.ts
  0:0  warning  File ignored because of a matching ignore pattern. Use "--no-ignore" to override

/builds/project/project/src/frontend/apps/project/src/app/app.component.ts
  0:0  error  Parsing error: Cannot read file '/tsconfig.json'

...

/builds/project/project/src/frontend/libs/workspace/src/lib/services/workspace-explorer.service.ts
  0:0  error  Parsing error: Cannot read file '/tsconfig.json'

/builds/project/project/src/frontend/libs/workspace/src/lib/services/workspace-toasts.service.ts
  0:0  error  Parsing error: Cannot read file '/tsconfig.json'

/builds/project/project/src/frontend/libs/workspace/src/lib/workspace.module.ts
  0:0  error  Parsing error: Cannot read file '/tsconfig.json'

✖ 724 problems (697 errors, 27 warnings)

section_end:`1678000239143152204`:processed-TYPESCRIPT_ES


+----SUMMARY----+----------+---------------+-------+-------+--------+--------------+
| Descriptor    | Linter   | Mode          | Files | Fixed | Errors | Elapsed time |
+---------------+----------+---------------+-------+-------+--------+--------------+
| ❌ TYPESCRIPT | eslint   | list_of_files |   724 |       |    724 |       47.67s |
| ◬ TYPESCRIPT  | prettier | list_of_files |   724 |       |      1 |        7.85s |
+---------------+----------+---------------+-------+-------+--------+--------------+

You could have same capabilities but better runtime performances if you use a MegaLinter flavor:
- [javascript] oxsecurity/megalinter/flavors/javascript@1.28.0 (56 linters) https://megalinter.io/1.28.0/flavors/javascript/
- [cupcake] oxsecurity/megalinter/flavors/cupcake@1.28.0 (80 linters) https://megalinter.io/1.28.0/flavors/cupcake/

[Gitlab Comment Reporter] No merge request has been found, so no comment has been posted
Unable to find git repository to list updated files
[Updated Sources Reporter] No source file has been formatted or fixed
❌ Error(s) have been found during linting
To disable linters or customize their checks, you can use a .mega-linter.yml file at the root of your repository
More info at https://megalinter.io/1.28.0/configuration/

[Gainutdinov]

On a side note, I suspect you should have env.browser and env.jest set to true.

I will tell FrontendDevs regarding this thank you :)

[Kurt-von-Laven]

I believe @typescript-eslint/parser should be a devDependency, but I can't imagine this would break ESLint. What is in your tsconfig.json? Since you mentioned .tsconfig.json earlier, can you confirm that you only have a tsconfig.json and not also a .tsconfig.json? You have a bunch of @angular-eslint and *eslint-plugin* packages installed, but I don't see where they are used. You might want to confirm that you can reproduce the issue with a more minimal package.json.

[Gainutdinov]

Confirm, tsconfig.json is the only one in the DEFAULT_WORKSPACE: "/builds/project/project/src/frontend", besides I can find another tsconfig.json files in subdirectories but I think they doesn't disturb the linter execution.

.tsconfig.json doesn't occure in any repo directory.

here is the example of my tsconfig.json

{
  "extends": "./tsconfig.base.json",
  "compilerOptions": {
    "alwaysStrict": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "noImplicitThis": true,
    "strictBindCallApply": true,

    "noPropertyAccessFromIndexSignature": true,
    "noUncheckedIndexedAccess": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,

    "forceConsistentCasingInFileNames": true,
    "noImplicitOverride": true,

    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "suppressExcessPropertyErrors": true,
    "suppressImplicitAnyIndexErrors": true
  },
  "angularCompilerOptions": {
    "strictInjectionParameters": true,
    "strictInputAccessModifiers": true,
    "strictTemplates": true
  }
}

[Kurt-von-Laven]

That looks reasonable to me. I would try again with LOG_LEVEL: DEBUG this time at MegaLinter v6.20.1 now that it's been released so we can get more visibility into what may be going wrong.

[Gainutdinov]

That looks reasonable to me. I would try again at MegaLinter v6.20.1 now that it's been released with LOG_LEVEL: DEBUG this time so we can get more visibility into what may be going wrong.

Thank you in advance.

[nvuillam]

NODE_ENV=production is set in MegaLinter image, maybe this has an impact ?

[Gainutdinov]

Let me try...

[Gainutdinov]

Added NODE_ENV=production to the gitlab job still the same error :( I can show my config via Discord if I it helps please let me know.

[Kurt-von-Laven]

I don't see why adding NODE_ENV=production would help. Are you able to share the results of running with LOG_LEVEL: DEBUG publicly?

[Gainutdinov]

saved log here replaced and removed sensitive information, please let me know I can share info via Discord if it helps.

[Kurt-von-Laven]

The Bitwarden didn't link work for me. My experience was similar to this one on both Chrome and Firefox on Ubuntu. I would either produce a minimal reproduction or excise enough out of the DEBUG level logs that you can share the portions relevant to TYPESCRIPT_ES publicly.

[Gainutdinov]

Excuse me, recreated the link, now log should be downlodable.

[Kurt-von-Laven]

Do you have TYPESCRIPT_ES_CLI_LINT_MODE set via an environment variable (possibly directly on the command line)? I see TYPESCRIPT_ES_CLI_LINT_MODE=list_of_files, so the workaround wasn't applied.

[Gainutdinov]

I tried TYPESCRIPT_ES_CLI_LINT_MODE=project but problem that even with project value and when I intentionally make a mistake in code the linter doesn't catch the error whereas in WebStorm it exists.

[Kurt-von-Laven]

Yikes; good catch. I am able to reproduce the fact that ESLint isn't actually running any longer at v6.20.1 when in project mode. I can see from https://github.com/oxsecurity/megalinter/issues/1572#issuecomment-1172194200 that it was working at v5.15.0, so we can narrow down the release in which the issue was introduced using binary search. This is a good argument for improving our test coverage since it can take a long time for anyone to notice if a linter starts unconditionally succeeding.

[bdovaz]

@Kurt-von-Laven indeed. I already refactored the testing infrastructure to introduce the format/autofix tests because in that case it was the same, it could take a long time for someone to use/test/check a linter with APPLY_FIXES.

Another improvement I can think of is to test LINT_MODE because in theory if you define file also project is implicit and if you define list_of_files file and project are implicit. But this is never tested, only the lint_mode declared in the descriptor is tested, not the rest.

cc @nvuillam @echoix

[Gainutdinov]

Is there anything I can assist? Let me conclude all above conversation:

• TYPESCRIPT_ES_CONFIG ignores any non-standard config files even when file exists and syntactically correct.
• TYPESCRIPT_ES doesn't catch errors and ignores variable DEFAULT_WORKSPACE, so it always uses / path for searching eslint config files.

[Kurt-von-Laven]

No, TYPESCRIPT_ES_CONFIG_FILE isn't ignored. To see this, try setting it to a blatantly invalid ESLint config (e.g., tsconfig.json), and ESLint will yield an appropriate error message when run via MegaLinter. I don't think there's evidence of the second bullet point either at this point? My assumption that ESLint worked in project mode at MegaLinter v5.15.0 was wrong; it has been silently succeeding for quite some time. The issue with running ESLint in project mode via MegaLinter is that we fail to pass in the directory to run on. We incorrectly execute eslint --no-ignore --fix rather than the correct eslint --no-ignore --fix .. The former command immediately and, more or less unconditionally, exits successfully, while the latter command runs ESLint on the current directory as expected. I see a few linters that always run in project mode set:

cli_lint_extra_args_after:
      - "."

However, this wouldn't work in list_of_files mode. On the other hand, list_of_files mode doesn't work for ESLint right now anyways, so I am tempted to use cli_lint_extra_args_after and force ESLint to run in project mode to put out the fire here.

[Kurt-von-Laven]

@Gainutdinov, yes, we are using Yarn, which complicates testing this change, so I could use some help trying out a workaround if you happen to be using npm. I would try TYPESCRIPT_ES_ARGUMENTS: . in conjunction with TYPESCRIPT_ES_CLI_LINT_MODE: project. I can tell it's at least a step in the right direction in our projects, but I don't know whether ESLint would be able to find the tsconfig.json we extend (Parsing error: File '@tsconfig/node18-strictest-esm/tsconfig.json' not found) if we were using npm rather than Yarn.

[Gainutdinov]

Thank you @Kurt-von-Laven, I will try your suggestions and will report the result.

[Gainutdinov]

checked, indeed, when using arguments below eslint started to work:

...
TYPESCRIPT_ES_CLI_LINT_MODE: project
TYPESCRIPT_ES_ARGUMENTS: .
...

Trying to check different config file names for eslint.

[Gainutdinov]

Regarding the following point: _TYPESCRIPT_ESCONFIG ignores any non-standard config files even when file exists and syntactically correct. Have checked one more time from my point the problem exists, what I mean, when renamed my .eslintrc.json to .eslintrc and set appropriate value in variables - TYPESCRIPT_ES_CONFIG=.eslintrc es_linter doesn't get activated and in job's log I see the following error. Please let me know if I miss something :)

[Activation] TYPESCRIPT_ES has been set inactive, as none of these files has been found: ['.eslintrc.json', '.eslintrc.yml', '.eslintrc.yaml', '.eslintrc.js', '.eslintrc.cjs', 'package.json:eslintConfig']

[nvuillam]

That an error on our side, .eslintrc is not in the list of file names that activate eslint ^^

[Gainutdinov]

Thank you again 😊 Just to clarify that I understood correctly when I set TYPESCRIPT_ES_CONFIG=.eslintrc ideally megalinter should try to find .eslintrc file for eslint config and if it finds it eslint should be activated, right?

[nvuillam]

Yes indeed :)

[Kurt-von-Laven]

.eslintrc isn't a config filename recognized by ESlint either though.

[nvuillam]

In that case let's not add it ^^

[Gainutdinov]

.eslintrc isn't a config filename recognized by ESlint either though.

Agree, I just though that in case of usage non-standard names like myconfig.json linter should recognize it with TYPESCRIPT_ES_CONFIG=myconfig.json (as described in eslint where you can provide non-standard config file names like this --config my config.json) but you better know :)

[nvuillam]

We should provide a way to override the descriptor property, indeed :) But not add them as default ^^

[Kurt-von-Laven]

We could change the core to activate a linter if either any of the files that activate it are found or its *CONFIG_FILE is found. That way users could mostly continue to not have to know or think about active_only_if_file_found. Can anyone think of a counterexample where this behavior might be problematic? Are there linters that use active_only_if_file_found for something other than their config file, for instance?

[Kurt-von-Laven]

My hack trying to use cli_lint_extra_args_after resulted in some test failures. I discovered we already have EslintLinter.py, and realized list_of_files mode does work in CI, so I modified EslintLinter.py to append . to ESLint's command line in project mode only.