search

oxsecurity / megalinter

🦙 MegaLinter analyzes 50 languages, 22 formats, 21 tooling formats, excessive copy-pastes, spelling mistakes and security issues in your repository sources with a GitHub Action, other CI tools or locally.
https://megalinter.io
GNU Affero General Public License v3.0
1.8k stars 215 forks source link

enhancement: TFLint - fix deprecated argument in ".tflint.hcl" and other improvements #3688

Closed TommyE123 closed 6 days ago

TommyE123 commented 6 days ago

TFLint fix deprecated argument in ".tflint.hcl"

Fixes #3618

Context:

@mg-alanjones kindly highlighted a warning appearing when running TFLINT. WARNING: "module" attribute in /action/lib/.automation/.tflint.hcl is deprecated. Use "call_module_type" instead. I’ve fixed this along with some improvements.

Changes:

In the megalinter default template: • Updated the commented url https://github.com/terraform-linters/tflint/blob/master/docs/user-guide/config.md. • Switched from module = false to call_module_type = "local". • Added more plugins so it now supports AWS, AZUREARM and GOOGLE. Other changes: • Added more tests to support the 3 languages. • Documentation to suggest using a config refined to a language.

Testing:

AZURE PIPELINE – Terraform project using megalinter default template with forced linting error.

Before: image image

After: image

Note appears in tflint page

image

If there are any issues or concerns, please let me know, and I will address them promptly. Thank you for reviewing this PR and I look forward to your feedback. Tom

echoix commented 6 days ago

Looks great!

nvuillam commented 6 days ago

.... and @TommyE123 strikes again ! :) Thanks :)