Closed jberkers42 closed 3 years ago
Are there differences between the dotnet installed version and the npm one ?
As dotnet is quite heavy, i would like to avoid to install it on all flavors, so the current implementation fits with that wish ^^
It is looking like the NPM version is now locked at 1.11 (as in, no longer developed), but that's just a feeling I get. Since there has been no response on the issue you raised, I am not sure what the plans are overall.
The main change is that this should now be able to run in the "all" flavor, however, since dotnet is not part of the JavaScript flavor, it would likely need to be dropped from that. Given the dotnet flavor includes dotnet, it should work fine there on the newer version.
I get that dotnet is heavy, so this is not suitable for all flavors.
@jberkers42 I hear you, I made an attempt in PR #699 , let's see what the CI says :)
The only downside is that javascript flavor will not contain it anymore (i don't want to increase the size one of the most used MegaLinter flavor for a rare use case), so projects with JS & tqsl will have to use main flavor
@jberkers42 it seems it works, thanks a lot for the suggestion :)
Thanks once again for the quick response.
Hey There,
Wasn't sure whether to raise a new feature request, or what exactly.
I was checking on the tsqllint project whether any progress had been made towards supporting Alpine linux without requiring compat libraries.
It seems that the tool was recently updated to support .NET version 5.0, and it's primary deployment method changed from node_module to .NET Tool. It is now installed using:
In any case, I thought I would try it out in the current build of the mega-linter:v4 docker image, and it seems to run fine.
When you have time, no urgency, it might now be feasible to add it to the general mega-linter image as well using this mechanism instead of the
npm install
method.Steps to install as follows:
I also tried linting some files, both with and without "errors", and had success there also.
Please let me know if you have any questions/comments.
Regards, JohnB