Add a pre-commit hook to check flake8 compliance and prevent commits to main branch

oxullo / sensorflux

Service relay for sensors to influxdb

0 stars 2 forks source link

Add a pre-commit hook to check flake8 compliance and prevent commits to main branch #8

Closed 19201080 closed 3 years ago

19201080 commented 3 years ago

Branches will need to be named either feature/name_of_branch or fix/name_of_branch. Resolves #6.

oxullo commented 3 years ago

@19201080 awesome! I'd suggest to add an entry to the README to describe how to install the reqs, install the hook and run a first manual test, so the process is clear.

oxullo commented 3 years ago

@19201080 one last thing:

https://github.com/oxullo/sensorflux/pull/8/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R8

here I'd use

$ python -m venv .venv

to create a local virtualenv (which will be also ready to be picked up by pycharm). If you prefer to use pyenv, then instead of sourcing the activate you should:

$ pyenv activate <ident>