search

oxwhirl / smac

SMAC: The StarCraft Multi-Agent Challenge
MIT License
1.03k stars 228 forks source link

Update protobuf version and fix compatibility with latest numpy versions #117

Closed thomasbbrunner closed 10 months ago

thomasbbrunner commented 10 months ago

Usage of np.bool, np.int and np.float is deprecated in recent numpy versions and throws an error. Here I replace np.bool with bool, as recommended by the numpy documentation. Reference: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Moreover, the protobuf version specified is incompatible with recent Ray versions (and therefore rllib). Thus, I bumped the protobuf version to the same as the one used in SMACv2.

These changes should not alter the code behavior.

thomasbbrunner commented 10 months ago

Any update on this? Maybe @samvelyan?

samvelyan commented 10 months ago

Hi @thomasbbrunner. Many thanks for your contribution. All looks good to me.