search

oxwhirl / smacv2

MIT License
197 stars 30 forks source link

Some bugs in readme #14

Closed liyang619 closed 1 year ago

liyang619 commented 1 year ago

Hi, I find some problems in your readme, which may confuse us. 1) In the "capability config" and code example", the item ""n_enemies": 5 " shouldn't be under strat_positions, it is should be closed to "n_unit". 2) it imports from smac in the example code, you should import from smacv2?

Besides, which version of pettingzoo do you use? I cannot run the example code of pettingzoo, which raises error "ImportError: cannot import name 'from_parallel_wrapper' from 'pettingzoo.utils.conversions'".

benellis3 commented 1 year ago

Thanks very much for the feedback on the readme, that's very useful! I will make some edits to that tomorrow.

On PettingZoo, I haven't tested the pettingzoo wrapper so currently do not know whether it works. Let me know if it breaks and I will have a quick look at getting it to work -- it shouldn't be too bad hopefully. @mingfeisun in another thread says 1.8.1 should be the version of pettingzoo that is used.

liyang619 commented 1 year ago

Thanks. The 1.8.1 works for me.