oxySmith / webdocs-assignment2

2 stars 0 forks source link

Header Component #5

Closed lekankoku closed 2 years ago

lekankoku commented 2 years ago

The header is a component that is used on all pages, hence we decided to componentize it via HTML Web Components Acceptance Criteria

Wireframe image

lekankoku commented 2 years ago

image @oxySmith @li-btu there was no color specified for the nav links, am I allowed to choose the color or if not what color code is this(the home text) ?

lekankoku commented 2 years ago

@oxySmith @li-btu is it also necessary to have the black separators separating the links?

li-btu commented 2 years ago

@lakeside213 You may use white color for the nav links, and a light yellow color of your choice when hovered. The separators are not necessary.

Our base color is orange(#F38D3F) and accent color is light yellow. Other than these colors you can use white and shades of grey.

lekankoku commented 2 years ago

@li-btu @oxySmith i've been able to implement a prototype of the header, can you pull the current develop branch and check it out on the index.html page and give me a review.

NB:check out the mobile view as well

li-btu commented 2 years ago

@lakeside213 It would be better if you could keep a minimum distance between each word when the browser size is squeezed. image

lekankoku commented 2 years ago

@li-btu i've fixed that by using a media query which starts from that screen width, pull the latest changes

@lakeside213 It would be better if you could keep a minimum distance between each word when the browser size is squeezed. image

lekankoku commented 2 years ago

In closing are you @li-btu @oxySmith satisfied with the header ?

li-btu commented 2 years ago

@lakeside213 It looks nice. There are only some minor things to improve.

  1. The texts on the navigation bar in the mobile version currently do not change color when hovered. Please change its color to light yellow when hovered and underline the page the user is currently on.
  2. When the brand name or logo is clicked, it should redirect to the home page.
lekankoku commented 2 years ago
  1. There are no hover events for mobile(you literally can only click and long press on mobiles)
li-btu commented 2 years ago

Regarding #1, sorry, I mean the desktop version when the browser is small enough

lekankoku commented 2 years ago

i've fixed the issues can you check the develop branch again @li-btu

li-btu commented 2 years ago

Looks good now. Thanks