search

oxySmith / webdocs-assignment2

2 stars 0 forks source link

Footer component #6

Closed lekankoku closed 2 years ago

lekankoku commented 2 years ago

The Footer is a component that is used on all pages, hence we decided to componentize it via HTML Web Components Acceptance Criteria

The footer should scale according to web view image

lekankoku commented 2 years ago

@oxySmith @li-btu I've implemented the footer, can you review it

oxySmith commented 2 years ago

@lakeside213 seems nice to me, you may fix typo in word 'Conditions' and separate the links 'Terms and conditions' and 'Credits' image

lekankoku commented 2 years ago

@oxySmith i've fixed the typo and i've also hyperlinked the credits page as well

lekankoku commented 2 years ago

In closing are you @li-btu @oxySmith satisfied with the footer ?

oxySmith commented 2 years ago

@lakeside213 yes, footer is nice