dart lint, removed api key, fixed error in text scaffold

oxyfalcon / firebase_todo

3 stars 2 forks source link

dart lint, removed api key, fixed error in text scaffold #17

Closed oxyfalcon closed 6 months ago

oxyfalcon commented 6 months ago

Changed the workflow by adding flutter pub get and upgrade
Added flutter analyze for static compile time errors
Fixed the minor issue in the #15
@skfareeduddin Please check the code once for future reference. Also do be careful in the future about the static errors

oxyfalcon commented 6 months ago

@bonamiAkash Please check the code once

bonamiAkash commented 6 months ago

Why did you remove the google files @oxyfalcon

oxyfalcon commented 6 months ago

@bonamiAkash Making sure the api key doesn't get exposed. Besides I think it is better if the people who want to contribute to the project setup their own firebase console.

bonamiAkash commented 6 months ago

Makes sense then

bonamiAkash commented 6 months ago

Also it is a good thing that you added in the flutter analyse command in the workflow @oxyfalcon Good lesson to be learnt here.